Angad Tendulkar comments

Results 20 comments of


                                            Angad Tendulkar

Dynamically deserialize networktables structs

Thanks for reviewing it and sorry for the late reply. Comps keep me busy! DynStructSchema is a data class that contains the schema of the struct (i.e. fields and field...

Dynamically deserialize networktables structs

I went ahead and removed ntStructMeta from the multitopic widgets

Dynamically deserialize networktables structs

i was in the middle of adding typechecking to nt types so I committed those changes too. im going to mark this as a draft until i finish fixing tests

Dynamically deserialize networktables structs

Also there's a problem where widgets in list layouts are too small. Dunno why that's happening; afaik I didn't change anything relating to that

Dynamically deserialize networktables structs

i successfully managed to rebase this onto the new formatter branch

Suggestion: Option to disable baritone's automatic movement

bump

Use impl Into for where and setparams, create functions

I know that it will clone anyways, the point is that the API allows you to borrow it. Tuple struct only containing one type would also be useful, you can...

Use impl Into for where and setparams, create functions

> lot of PCR's design decisions revolve around function arguments having discrete types rather than generics I skipped using impl Into for any generic types because that would just not...

Use impl Into for where and setparams, create functions

@Brendonovich I believe this PR should be ready to merge, I removed impl Into's for the query params as they would conflict. Could you please review this pr?

Use impl Into for where and setparams, create functions

Personally, I prefer a good DX, and impl Into's remove a lot of boilerplate. If you disagree, I'll probably just keep my repo synced with your master and use that...