optic icon indicating copy to clipboard operation
optic copied to clipboard

hrtime permission is not a thing in Deno 2.0

Open erkiesken opened this issue 1 year ago • 3 comments

Looks like there are checks for a removed permission that fail now in Deno 2.0:

error: Uncaught (in promise) TypeError: The provided value "hrtime" is not a valid permission name
  (await Deno.permissions.query({ name: "hrtime" })).state === "granted";
                          ^
    at Permissions.querySync (ext:runtime/10_permissions.js:211:13)
    at Permissions.query (ext:runtime/10_permissions.js:203:34)
    at https://deno.land/x/[email protected]/utils/numberFormatter.ts:3:27

Release notes

I was using:

$ deno --version
deno 2.0.0 (stable, release, x86_64-unknown-linux-gnu)
v8 12.9.202.13-rusty
typescript 5.6.2

erkiesken avatar Oct 18 '24 10:10 erkiesken

console.log(Deno.version)

import { Logger } from "https://deno.land/x/optic/mod.ts";

const logger = new Logger();
logger.info("Hello world!"); 

Generates following output/error


{ deno: "2.0.0", v8: "12.9.202.13-rusty", typescript: "5.6.2" }
Stack trace:
TypeError: The provided value "hrtime" is not a valid permission name
    at Permissions.querySync (ext:runtime/10_permissions.js:211:13)
    at Permissions.query (ext:runtime/10_permissions.js:203:34)
    at https://deno.land/x/[email protected]/utils/numberFormatter.ts:3:27

rajeshpv avatar Oct 31 '24 18:10 rajeshpv

Thanks both. I'm currently working on migrating this library to Deno 2 and JSR.

cknight avatar Nov 01 '24 17:11 cknight

@cknight Thanks and appreciate for all the work, really. I tested it is working with deno 2.0.6.

hint for others

  • run with reload to recache optic with newer version as follows:
  • deno run -A --reload bin.ts
  • where bin.ts has below code
// bin.ts
import { Logger } from "https://deno.land/x/optic/mod.ts";
// or
// import { Logger } from "jsr:@onjara/optic/logger";

const logger = new Logger();
logger.info("Hello world!"); 

rajeshpv avatar Nov 15 '24 05:11 rajeshpv