oni2 icon indicating copy to clipboard operation
oni2 copied to clipboard

Provided binaries don't work on Arch Linux anymore

Open despairblue opened this issue 4 years ago • 51 comments

I'm getting this when I start it:

symbol lookup error: /usr/lib/libgio-2.0.so.0: undefined symbol: g_module_open_full

I supposed glib2 has been upgraded and is not not compatible anymore.

despairblue avatar Sep 25 '21 14:09 despairblue

I tried to build it manually, which failed for, I think, a different reason:

Build Log
info building esy-skia@github:revery-ui/esy-skia#60e0260@d41d8cd9
error: build failed with exit code: 1
  build log:
    # esy-build-package: building: esy-skia@github:revery-ui/esy-skia#60e0260
    # esy-build-package: pwd: /home/despairblue/.esy/3/b/esy_skia-01fafb2b
    # esy-build-package: running: 'bash' './esy/build.sh' 'linux' '/home/despairblue/.esy/3_____________________________________________________________/i/esy_libjpeg_turbo-e4385a3b'
    buildtools                           @ 505de88083136eefd056e5ee4ca0f01fe9b33de8
    common                               @ 9737551d7a52c3db3262db5856e6bcd62c462b92
    third_party/externals/angle2         @ b001528ffa00e7c15a5002124f707570e59a5697
    third_party/externals/dng_sdk        @ 96443b262250c390b0caefbf3eed8463ba35ecae
    third_party/externals/expat          @ android-6.0.1_r55
    third_party/externals/freetype       @ fa6da7bf6dcbcfa22d2464259ad1cccee3233189
    third_party/externals/googletest     @ dd43b9998e9a44a579a7aba6c1309407d1a5ed95
    third_party/externals/harfbuzz       @ 1.4.2
    third_party/externals/icu            @ ec9c1133693148470ffe2e5e53576998e3650c1d
    third_party/externals/imgui          @ 6384eee34f08cb7eab8d835043e1738e4adcdf75
    third_party/externals/jsoncpp        @ 1.0.0
    third_party/externals/libjpeg-turbo  @ 1.5.3
    third_party/externals/libpng         @ v1.6.33
    third_party/externals/libwebp        @ v0.6.1
    third_party/externals/lua            @ v5-3-4
    third_party/externals/microhttpd     @ 748945ec6f1c67b7efc934ab0808e1d32f2fb98d
    third_party/externals/piex           @ bb217acdca1cc0c16b704669dd6f91a1b509c406
    third_party/externals/rapidjson      @ af223d44f4e8d3772cb1ac0ce8bc2a132b51717f
    third_party/externals/sdl            @ 5d7cfcca344034aff9327f77fc181ae3754e7a90
    third_party/externals/sfntly         @ b18b09b6114b9b7fe6fc2f96d8b15e8a72f66916
    third_party/externals/spirv-headers  @ 661ad91124e6af2272afd00f804d8aa276e17107
    third_party/externals/spirv-tools    @ e9e4393b1c5aad7553c05782acefbe32b42644bd
    third_party/externals/swiftshader    @ cbb80f5f0078a9941f3ec43e83e52c3d15a43bea
    third_party/externals/zlib           @ e7afdfe128e01ca480a28f757b571957befdd962
    llvm toolset-7.0 does not need to be manually activated
    Done. Made 44 targets from 27 files in 33ms
    ninja: Entering directory `/home/despairblue/.esy/3/b/esy_skia-01fafb2b/out/Static'
    [1/1206] stamp obj/arm64.stamp
    [2/1206] stamp obj/compile_processors.stamp
    [3/1206] stamp obj/armv7.stamp
    [4/1206] stamp obj/crc32.stamp
    [5/1206] stamp obj/fontmgr_custom.stamp
    [6/1206] stamp obj/fontmgr_empty.stamp
    [7/1206] stamp obj/fontmgr_fuchsia.stamp
    [8/1206] compile ../../src/ports/SkFontConfigInterface.cpp
    FAILED: obj/src/ports/fontmgr_fontconfig.SkFontConfigInterface.o 
    clang++ -MMD -MF obj/src/ports/fontmgr_fontconfig.SkFontConfigInterface.o.d -DNDEBUG -DSK_SAMPLES_FOR_X -DSK_GAMMA_APPLY_TO_A8 -DSK_ENABLE_DISCRETE_GPU -DGR_TEST_UTILS=1 -DSKIA_IMPLEMENTATION=1 -I../../include/android -I../../include/c -I../../include/codec -I../../include/config -I../../include/core -I../../include/effects -I../../include/encode -I../../include/gpu -I../../include/atlastext -I../../include/pathops -I../../include/ports -I../../include/svg -I../../include/utils -I../../include/utils/mac -I../../include/private -I../../src/c -I../../src/codec -I../../src/core -I../../src/effects -I../../src/fonts -I../../src/image -I../../src/images -I../../src/lazy -I../../src/opts -I../../src/pathops -I../../src/pdf -I../../src/ports -I../../src/sfnt -I../../src/shaders -I../../src/shaders/gradients -I../../src/sksl -I../../src/utils -I../../src/utils/win -I../../src/xml -I../../third_party/gif -I../../src/gpu -fstrict-aliasing -fPIC -fvisibility=hidden -O3 -fdata-sections -ffunction-sections -g -Werror -Wall -Wextra -Winit-self -Wpointer-arith -Wsign-compare -Wvla -Wno-deprecated-declarations -Wno-maybe-uninitialized -Wno-extra-semi-stmt -Weverything -Wno-unknown-warning-option -Wno-anon-enum-enum-conversion -Wno-sizeof-array-div -Wno-nonportable-include-path -Wno-nonportable-system-include-path -Wno-cast-align -Wno-cast-qual -Wno-conversion -Wno-disabled-macro-expansion -Wno-documentation -Wno-documentation-unknown-command -Wno-double-promotion -Wno-exit-time-destructors -Wno-float-equal -Wno-format-nonliteral -Wno-global-constructors -Wno-missing-prototypes -Wno-missing-variable-declarations -Wno-pedantic -Wno-reserved-id-macro -Wno-shadow -Wno-shift-sign-overflow -Wno-signed-enum-bitfield -Wno-switch-enum -Wno-undef -Wno-unreachable-code -Wno-unreachable-code-break -Wno-unreachable-code-return -Wno-unused-macros -Wno-unused-member-function -Wno-unused-template -Wno-zero-as-null-pointer-constant -Wno-bad-function-cast -Wno-covered-switch-default -Wno-deprecated -Wno-missing-noreturn -Wno-old-style-cast -Wno-padded -Wno-newline-eof -Wno-implicit-fallthrough -Wno-unused-parameter -I/home/despairblue/.esy/3_____________________________________________________________/i/esy_libjpeg_turbo-e4385a3b/include -Wno-poison-system-directories -std=c++11 -fvisibility-inlines-hidden -fno-exceptions -fno-rtti -Wnon-virtual-dtor -Wno-noexcept-type -Wno-abstract-vbase-init -Wno-weak-vtables -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undefined-func-template -c ../../src/ports/SkFontConfigInterface.cpp -o obj/src/ports/fontmgr_fontconfig.SkFontConfigInterface.o
    In file included from ../../src/ports/SkFontConfigInterface.cpp:8:
    In file included from ../../include/ports/SkFontConfigInterface.h:13:
    ../../include/core/SkTypeface.h:304:13: error: '~SkTypeface' overrides a destructor but is not marked 'override' [-Werror,-Wsuggest-destructor-override]
        virtual ~SkTypeface();
                ^
    ../../include/core/../private/SkWeakRefCnt.h:63:5: note: overridden virtual function is here
        ~SkWeakRefCnt() override {
        ^
    1 error generated.
    [9/1206] compile ../../src/gpu/GrBackendSurface.cpp
    [10/1206] compile ../../src/effects/Sk2DPathEffect.cpp
    FAILED: obj/src/effects/effects.Sk2DPathEffect.o 
    clang++ -MMD -MF obj/src/effects/effects.Sk2DPathEffect.o.d -DNDEBUG -DSK_SAMPLES_FOR_X -DSK_GAMMA_APPLY_TO_A8 -DSK_ENABLE_DISCRETE_GPU -DGR_TEST_UTILS=1 -DSKIA_IMPLEMENTATION=1 -I../../include/android -I../../include/c -I../../include/codec -I../../include/config -I../../include/core -I../../include/effects -I../../include/encode -I../../include/gpu -I../../include/atlastext -I../../include/pathops -I../../include/ports -I../../include/svg -I../../include/utils -I../../include/utils/mac -I../../include/private -I../../src/c -I../../src/codec -I../../src/core -I../../src/effects -I../../src/fonts -I../../src/image -I../../src/images -I../../src/lazy -I../../src/opts -I../../src/pathops -I../../src/pdf -I../../src/ports -I../../src/sfnt -I../../src/shaders -I../../src/shaders/gradients -I../../src/sksl -I../../src/utils -I../../src/utils/win -I../../src/xml -I../../third_party/gif -I../../src/gpu -fstrict-aliasing -fPIC -fvisibility=hidden -O3 -fdata-sections -ffunction-sections -g -Werror -Wall -Wextra -Winit-self -Wpointer-arith -Wsign-compare -Wvla -Wno-deprecated-declarations -Wno-maybe-uninitialized -Wno-extra-semi-stmt -Weverything -Wno-unknown-warning-option -Wno-anon-enum-enum-conversion -Wno-sizeof-array-div -Wno-nonportable-include-path -Wno-nonportable-system-include-path -Wno-cast-align -Wno-cast-qual -Wno-conversion -Wno-disabled-macro-expansion -Wno-documentation -Wno-documentation-unknown-command -Wno-double-promotion -Wno-exit-time-destructors -Wno-float-equal -Wno-format-nonliteral -Wno-global-constructors -Wno-missing-prototypes -Wno-missing-variable-declarations -Wno-pedantic -Wno-reserved-id-macro -Wno-shadow -Wno-shift-sign-overflow -Wno-signed-enum-bitfield -Wno-switch-enum -Wno-undef -Wno-unreachable-code -Wno-unreachable-code-break -Wno-unreachable-code-return -Wno-unused-macros -Wno-unused-member-function -Wno-unused-template -Wno-zero-as-null-pointer-constant -Wno-bad-function-cast -Wno-covered-switch-default -Wno-deprecated -Wno-missing-noreturn -Wno-old-style-cast -Wno-padded -Wno-newline-eof -Wno-implicit-fallthrough -Wno-unused-parameter -I/home/despairblue/.esy/3_____________________________________________________________/i/esy_libjpeg_turbo-e4385a3b/include -Wno-poison-system-directories -std=c++11 -fvisibility-inlines-hidden -fno-exceptions -fno-rtti -Wnon-virtual-dtor -Wno-noexcept-type -Wno-abstract-vbase-init -Wno-weak-vtables -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undefined-func-template -c ../../src/effects/Sk2DPathEffect.cpp -o obj/src/effects/effects.Sk2DPathEffect.o
    In file included from ../../src/effects/Sk2DPathEffect.cpp:10:
    In file included from ../../src/core/SkReadBuffer.h:12:
    In file included from ../../include/core/SkSerialProcs.h:13:
    ../../include/core/SkTypeface.h:304:13: error: '~SkTypeface' overrides a destructor but is not marked 'override' [-Werror,-Wsuggest-destructor-override]
        virtual ~SkTypeface();
                ^
    ../../include/core/../private/SkWeakRefCnt.h:63:5: note: overridden virtual function is here
        ~SkWeakRefCnt() override {
        ^
    1 error generated.
    [11/1206] compile ../../src/effects/Sk1DPathEffect.cpp
    FAILED: obj/src/effects/effects.Sk1DPathEffect.o 
    clang++ -MMD -MF obj/src/effects/effects.Sk1DPathEffect.o.d -DNDEBUG -DSK_SAMPLES_FOR_X -DSK_GAMMA_APPLY_TO_A8 -DSK_ENABLE_DISCRETE_GPU -DGR_TEST_UTILS=1 -DSKIA_IMPLEMENTATION=1 -I../../include/android -I../../include/c -I../../include/codec -I../../include/config -I../../include/core -I../../include/effects -I../../include/encode -I../../include/gpu -I../../include/atlastext -I../../include/pathops -I../../include/ports -I../../include/svg -I../../include/utils -I../../include/utils/mac -I../../include/private -I../../src/c -I../../src/codec -I../../src/core -I../../src/effects -I../../src/fonts -I../../src/image -I../../src/images -I../../src/lazy -I../../src/opts -I../../src/pathops -I../../src/pdf -I../../src/ports -I../../src/sfnt -I../../src/shaders -I../../src/shaders/gradients -I../../src/sksl -I../../src/utils -I../../src/utils/win -I../../src/xml -I../../third_party/gif -I../../src/gpu -fstrict-aliasing -fPIC -fvisibility=hidden -O3 -fdata-sections -ffunction-sections -g -Werror -Wall -Wextra -Winit-self -Wpointer-arith -Wsign-compare -Wvla -Wno-deprecated-declarations -Wno-maybe-uninitialized -Wno-extra-semi-stmt -Weverything -Wno-unknown-warning-option -Wno-anon-enum-enum-conversion -Wno-sizeof-array-div -Wno-nonportable-include-path -Wno-nonportable-system-include-path -Wno-cast-align -Wno-cast-qual -Wno-conversion -Wno-disabled-macro-expansion -Wno-documentation -Wno-documentation-unknown-command -Wno-double-promotion -Wno-exit-time-destructors -Wno-float-equal -Wno-format-nonliteral -Wno-global-constructors -Wno-missing-prototypes -Wno-missing-variable-declarations -Wno-pedantic -Wno-reserved-id-macro -Wno-shadow -Wno-shift-sign-overflow -Wno-signed-enum-bitfield -Wno-switch-enum -Wno-undef -Wno-unreachable-code -Wno-unreachable-code-break -Wno-unreachable-code-return -Wno-unused-macros -Wno-unused-member-function -Wno-unused-template -Wno-zero-as-null-pointer-constant -Wno-bad-function-cast -Wno-covered-switch-default -Wno-deprecated -Wno-missing-noreturn -Wno-old-style-cast -Wno-padded -Wno-newline-eof -Wno-implicit-fallthrough -Wno-unused-parameter -I/home/despairblue/.esy/3_____________________________________________________________/i/esy_libjpeg_turbo-e4385a3b/include -Wno-poison-system-directories -std=c++11 -fvisibility-inlines-hidden -fno-exceptions -fno-rtti -Wnon-virtual-dtor -Wno-noexcept-type -Wno-abstract-vbase-init -Wno-weak-vtables -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undefined-func-template -c ../../src/effects/Sk1DPathEffect.cpp -o obj/src/effects/effects.Sk1DPathEffect.o
    In file included from ../../src/effects/Sk1DPathEffect.cpp:10:
    In file included from ../../src/core/SkReadBuffer.h:12:
    In file included from ../../include/core/SkSerialProcs.h:13:
    ../../include/core/SkTypeface.h:304:13: error: '~SkTypeface' overrides a destructor but is not marked 'override' [-Werror,-Wsuggest-destructor-override]
        virtual ~SkTypeface();
                ^
    ../../include/core/../private/SkWeakRefCnt.h:63:5: note: overridden virtual function is here
        ~SkWeakRefCnt() override {
        ^
    1 error generated.
    [12/1206] compile ../../src/gpu/GrPaint.cpp
    FAILED: obj/src/gpu/gpu.GrPaint.o 
    clang++ -MMD -MF obj/src/gpu/gpu.GrPaint.o.d -DNDEBUG -DSK_SAMPLES_FOR_X -DSK_GAMMA_APPLY_TO_A8 -DSK_ENABLE_DISCRETE_GPU -DGR_TEST_UTILS=1 -DSKIA_IMPLEMENTATION=1 -I../../include/android -I../../include/c -I../../include/codec -I../../include/config -I../../include/core -I../../include/effects -I../../include/encode -I../../include/gpu -I../../include/atlastext -I../../include/pathops -I../../include/ports -I../../include/svg -I../../include/utils -I../../include/utils/mac -I../../include/private -I../../src/c -I../../src/codec -I../../src/core -I../../src/effects -I../../src/fonts -I../../src/image -I../../src/images -I../../src/lazy -I../../src/opts -I../../src/pathops -I../../src/pdf -I../../src/ports -I../../src/sfnt -I../../src/shaders -I../../src/shaders/gradients -I../../src/sksl -I../../src/utils -I../../src/utils/win -I../../src/xml -I../../third_party/gif -I../../src/gpu -fstrict-aliasing -fPIC -fvisibility=hidden -O3 -fdata-sections -ffunction-sections -g -Werror -Wall -Wextra -Winit-self -Wpointer-arith -Wsign-compare -Wvla -Wno-deprecated-declarations -Wno-maybe-uninitialized -Wno-extra-semi-stmt -Weverything -Wno-unknown-warning-option -Wno-anon-enum-enum-conversion -Wno-sizeof-array-div -Wno-nonportable-include-path -Wno-nonportable-system-include-path -Wno-cast-align -Wno-cast-qual -Wno-conversion -Wno-disabled-macro-expansion -Wno-documentation -Wno-documentation-unknown-command -Wno-double-promotion -Wno-exit-time-destructors -Wno-float-equal -Wno-format-nonliteral -Wno-global-constructors -Wno-missing-prototypes -Wno-missing-variable-declarations -Wno-pedantic -Wno-reserved-id-macro -Wno-shadow -Wno-shift-sign-overflow -Wno-signed-enum-bitfield -Wno-switch-enum -Wno-undef -Wno-unreachable-code -Wno-unreachable-code-break -Wno-unreachable-code-return -Wno-unused-macros -Wno-unused-member-function -Wno-unused-template -Wno-zero-as-null-pointer-constant -Wno-bad-function-cast -Wno-covered-switch-default -Wno-deprecated -Wno-missing-noreturn -Wno-old-style-cast -Wno-padded -Wno-newline-eof -Wno-implicit-fallthrough -Wno-unused-parameter -I/home/despairblue/.esy/3_____________________________________________________________/i/esy_libjpeg_turbo-e4385a3b/include -Wno-poison-system-directories -std=c++11 -fvisibility-inlines-hidden -fno-exceptions -fno-rtti -Wnon-virtual-dtor -Wno-noexcept-type -Wno-abstract-vbase-init -Wno-weak-vtables -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undefined-func-template -c ../../src/gpu/GrPaint.cpp -o obj/src/gpu/gpu.GrPaint.o
    In file included from ../../src/gpu/GrPaint.cpp:8:
    In file included from ../../src/gpu/GrPaint.h:14:
    In file included from ../../src/gpu/GrFragmentProcessor.h:11:
    In file included from ../../src/gpu/GrProcessor.h:15:
    In file included from ../../src/gpu/GrProcessorUnitTest.h:15:
    In file included from ../../include/android/../private/GrTextureProxy.h:12:
    ../../include/private/GrSurfaceProxy.h:399:13: error: '~GrSurfaceProxy' overrides a destructor but is not marked 'override' [-Werror,-Wsuggest-destructor-override]
        virtual ~GrSurfaceProxy();
                ^
    ../../include/private/GrSurfaceProxy.h:149:13: note: overridden virtual function is here
        virtual ~GrIORefProxy() {
                ^
    In file included from ../../src/gpu/GrPaint.cpp:8:
    In file included from ../../src/gpu/GrPaint.h:14:
    In file included from ../../src/gpu/GrFragmentProcessor.h:11:
    In file included from ../../src/gpu/GrProcessor.h:19:
    In file included from ../../src/gpu/GrSurfaceProxyPriv.h:13:
    In file included from ../../src/gpu/GrResourceProvider.h:15:
    In file included from ../../src/core/SkScalerContext.h:19:
    ../../include/core/SkTypeface.h:304:13: error: '~SkTypeface' overrides a destructor but is not marked 'override' [-Werror,-Wsuggest-destructor-override]
        virtual ~SkTypeface();
                ^
    ../../include/core/../private/SkWeakRefCnt.h:63:5: note: overridden virtual function is here
        ~SkWeakRefCnt() override {
        ^
    2 errors generated.
    [13/1206] compile ../../src/gpu/GrAuditTrail.cpp
    FAILED: obj/src/gpu/gpu.GrAuditTrail.o 
    clang++ -MMD -MF obj/src/gpu/gpu.GrAuditTrail.o.d -DNDEBUG -DSK_SAMPLES_FOR_X -DSK_GAMMA_APPLY_TO_A8 -DSK_ENABLE_DISCRETE_GPU -DGR_TEST_UTILS=1 -DSKIA_IMPLEMENTATION=1 -I../../include/android -I../../include/c -I../../include/codec -I../../include/config -I../../include/core -I../../include/effects -I../../include/encode -I../../include/gpu -I../../include/atlastext -I../../include/pathops -I../../include/ports -I../../include/svg -I../../include/utils -I../../include/utils/mac -I../../include/private -I../../src/c -I../../src/codec -I../../src/core -I../../src/effects -I../../src/fonts -I../../src/image -I../../src/images -I../../src/lazy -I../../src/opts -I../../src/pathops -I../../src/pdf -I../../src/ports -I../../src/sfnt -I../../src/shaders -I../../src/shaders/gradients -I../../src/sksl -I../../src/utils -I../../src/utils/win -I../../src/xml -I../../third_party/gif -I../../src/gpu -fstrict-aliasing -fPIC -fvisibility=hidden -O3 -fdata-sections -ffunction-sections -g -Werror -Wall -Wextra -Winit-self -Wpointer-arith -Wsign-compare -Wvla -Wno-deprecated-declarations -Wno-maybe-uninitialized -Wno-extra-semi-stmt -Weverything -Wno-unknown-warning-option -Wno-anon-enum-enum-conversion -Wno-sizeof-array-div -Wno-nonportable-include-path -Wno-nonportable-system-include-path -Wno-cast-align -Wno-cast-qual -Wno-conversion -Wno-disabled-macro-expansion -Wno-documentation -Wno-documentation-unknown-command -Wno-double-promotion -Wno-exit-time-destructors -Wno-float-equal -Wno-format-nonliteral -Wno-global-constructors -Wno-missing-prototypes -Wno-missing-variable-declarations -Wno-pedantic -Wno-reserved-id-macro -Wno-shadow -Wno-shift-sign-overflow -Wno-signed-enum-bitfield -Wno-switch-enum -Wno-undef -Wno-unreachable-code -Wno-unreachable-code-break -Wno-unreachable-code-return -Wno-unused-macros -Wno-unused-member-function -Wno-unused-template -Wno-zero-as-null-pointer-constant -Wno-bad-function-cast -Wno-covered-switch-default -Wno-deprecated -Wno-missing-noreturn -Wno-old-style-cast -Wno-padded -Wno-newline-eof -Wno-implicit-fallthrough -Wno-unused-parameter -I/home/despairblue/.esy/3_____________________________________________________________/i/esy_libjpeg_turbo-e4385a3b/include -Wno-poison-system-directories -std=c++11 -fvisibility-inlines-hidden -fno-exceptions -fno-rtti -Wnon-virtual-dtor -Wno-noexcept-type -Wno-abstract-vbase-init -Wno-weak-vtables -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undefined-func-template -c ../../src/gpu/GrAuditTrail.cpp -o obj/src/gpu/gpu.GrAuditTrail.o
    In file included from ../../src/gpu/GrAuditTrail.cpp:8:
    In file included from ../../include/private/GrAuditTrail.h:13:
    In file included from ../../include/private/GrRenderTargetProxy.h:11:
    ../../include/private/GrSurfaceProxy.h:399:13: error: '~GrSurfaceProxy' overrides a destructor but is not marked 'override' [-Werror,-Wsuggest-destructor-override]
        virtual ~GrSurfaceProxy();
                ^
    ../../include/private/GrSurfaceProxy.h:149:13: note: overridden virtual function is here
        virtual ~GrIORefProxy() {
                ^
    In file included from ../../src/gpu/GrAuditTrail.cpp:9:
    In file included from ../../src/gpu/ops/GrOp.h:15:
    In file included from ../../src/gpu/GrXferProcessor.h:14:
    In file included from ../../src/gpu/GrProcessor.h:19:
    In file included from ../../src/gpu/GrSurfaceProxyPriv.h:13:
    In file included from ../../src/gpu/GrResourceProvider.h:15:
    In file included from ../../src/core/SkScalerContext.h:19:
    ../../include/core/SkTypeface.h:304:13: error: '~SkTypeface' overrides a destructor but is not marked 'override' [-Werror,-Wsuggest-destructor-override]
        virtual ~SkTypeface();
                ^
    ../../include/core/../private/SkWeakRefCnt.h:63:5: note: overridden virtual function is here
        ~SkWeakRefCnt() override {
        ^
    2 errors generated.
    [14/1206] compile ../../src/gpu/GrPath.cpp
    FAILED: obj/src/gpu/gpu.GrPath.o 
    clang++ -MMD -MF obj/src/gpu/gpu.GrPath.o.d -DNDEBUG -DSK_SAMPLES_FOR_X -DSK_GAMMA_APPLY_TO_A8 -DSK_ENABLE_DISCRETE_GPU -DGR_TEST_UTILS=1 -DSKIA_IMPLEMENTATION=1 -I../../include/android -I../../include/c -I../../include/codec -I../../include/config -I../../include/core -I../../include/effects -I../../include/encode -I../../include/gpu -I../../include/atlastext -I../../include/pathops -I../../include/ports -I../../include/svg -I../../include/utils -I../../include/utils/mac -I../../include/private -I../../src/c -I../../src/codec -I../../src/core -I../../src/effects -I../../src/fonts -I../../src/image -I../../src/images -I../../src/lazy -I../../src/opts -I../../src/pathops -I../../src/pdf -I../../src/ports -I../../src/sfnt -I../../src/shaders -I../../src/shaders/gradients -I../../src/sksl -I../../src/utils -I../../src/utils/win -I../../src/xml -I../../third_party/gif -I../../src/gpu -fstrict-aliasing -fPIC -fvisibility=hidden -O3 -fdata-sections -ffunction-sections -g -Werror -Wall -Wextra -Winit-self -Wpointer-arith -Wsign-compare -Wvla -Wno-deprecated-declarations -Wno-maybe-uninitialized -Wno-extra-semi-stmt -Weverything -Wno-unknown-warning-option -Wno-anon-enum-enum-conversion -Wno-sizeof-array-div -Wno-nonportable-include-path -Wno-nonportable-system-include-path -Wno-cast-align -Wno-cast-qual -Wno-conversion -Wno-disabled-macro-expansion -Wno-documentation -Wno-documentation-unknown-command -Wno-double-promotion -Wno-exit-time-destructors -Wno-float-equal -Wno-format-nonliteral -Wno-global-constructors -Wno-missing-prototypes -Wno-missing-variable-declarations -Wno-pedantic -Wno-reserved-id-macro -Wno-shadow -Wno-shift-sign-overflow -Wno-signed-enum-bitfield -Wno-switch-enum -Wno-undef -Wno-unreachable-code -Wno-unreachable-code-break -Wno-unreachable-code-return -Wno-unused-macros -Wno-unused-member-function -Wno-unused-template -Wno-zero-as-null-pointer-constant -Wno-bad-function-cast -Wno-covered-switch-default -Wno-deprecated -Wno-missing-noreturn -Wno-old-style-cast -Wno-padded -Wno-newline-eof -Wno-implicit-fallthrough -Wno-unused-parameter -I/home/despairblue/.esy/3_____________________________________________________________/i/esy_libjpeg_turbo-e4385a3b/include -Wno-poison-system-directories -std=c++11 -fvisibility-inlines-hidden -fno-exceptions -fno-rtti -Wnon-virtual-dtor -Wno-noexcept-type -Wno-abstract-vbase-init -Wno-weak-vtables -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undefined-func-template -c ../../src/gpu/GrPath.cpp -o obj/src/gpu/gpu.GrPath.o
    In file included from ../../src/gpu/GrPath.cpp:8:
    In file included from ../../src/gpu/GrPath.h:12:
    In file included from ../../src/gpu/GrPathRendering.h:12:
    In file included from ../../src/gpu/GrPipeline.h:12:
    In file included from ../../src/gpu/GrFragmentProcessor.h:11:
    In file included from ../../src/gpu/GrProcessor.h:15:
    In file included from ../../src/gpu/GrProcessorUnitTest.h:15:
    In file included from ../../include/android/../private/GrTextureProxy.h:12:
    ../../include/private/GrSurfaceProxy.h:399:13: error: '~GrSurfaceProxy' overrides a destructor but is not marked 'override' [-Werror,-Wsuggest-destructor-override]
        virtual ~GrSurfaceProxy();
                ^
    ../../include/private/GrSurfaceProxy.h:149:13: note: overridden virtual function is here
        virtual ~GrIORefProxy() {
                ^
    In file included from ../../src/gpu/GrPath.cpp:8:
    In file included from ../../src/gpu/GrPath.h:12:
    In file included from ../../src/gpu/GrPathRendering.h:12:
    In file included from ../../src/gpu/GrPipeline.h:12:
    In file included from ../../src/gpu/GrFragmentProcessor.h:11:
    In file included from ../../src/gpu/GrProcessor.h:19:
    In file included from ../../src/gpu/GrSurfaceProxyPriv.h:13:
    In file included from ../../src/gpu/GrResourceProvider.h:15:
    In file included from ../../src/core/SkScalerContext.h:19:
    ../../include/core/SkTypeface.h:304:13: error: '~SkTypeface' overrides a destructor but is not marked 'override' [-Werror,-Wsuggest-destructor-override]
        virtual ~SkTypeface();
                ^
    ../../include/core/../private/SkWeakRefCnt.h:63:5: note: overridden virtual function is here
        ~SkWeakRefCnt() override {
        ^
    In file included from ../../src/gpu/GrPath.cpp:8:
    In file included from ../../src/gpu/GrPath.h:12:
    In file included from ../../src/gpu/GrPathRendering.h:12:
    In file included from ../../src/gpu/GrPipeline.h:16:
    In file included from ../../src/gpu/GrProgramDesc.h:15:
    ../../src/gpu/glsl/GrGLSLFragmentShaderBuilder.h:25:13: error: '~GrGLSLFragmentBuilder' overrides a destructor but is not marked 'override' [-Werror,-Wsuggest-destructor-override]
        virtual ~GrGLSLFragmentBuilder() {}
                ^
    ../../src/gpu/glsl/GrGLSLShaderBuilder.h:26:13: note: overridden virtual function is here
        virtual ~GrGLSLShaderBuilder() {}
                ^
    3 errors generated.
    [15/1206] compile ../../src/opts/SkOpts_avx.cpp
    FAILED: obj/src/opts/avx.SkOpts_avx.o 
    clang++ -MMD -MF obj/src/opts/avx.SkOpts_avx.o.d -DNDEBUG -DSK_SAMPLES_FOR_X -DSK_GAMMA_APPLY_TO_A8 -DSK_ENABLE_DISCRETE_GPU -DGR_TEST_UTILS=1 -DSKIA_IMPLEMENTATION=1 -I../../include/android -I../../include/c -I../../include/codec -I../../include/config -I../../include/core -I../../include/effects -I../../include/encode -I../../include/gpu -I../../include/atlastext -I../../include/pathops -I../../include/ports -I../../include/svg -I../../include/utils -I../../include/utils/mac -I../../include/private -I../../src/c -I../../src/codec -I../../src/core -I../../src/effects -I../../src/fonts -I../../src/image -I../../src/images -I../../src/lazy -I../../src/opts -I../../src/pathops -I../../src/pdf -I../../src/ports -I../../src/sfnt -I../../src/shaders -I../../src/shaders/gradients -I../../src/sksl -I../../src/utils -I../../src/utils/win -I../../src/xml -I../../third_party/gif -I../../src/gpu -mavx -fstrict-aliasing -fPIC -fvisibility=hidden -O3 -fdata-sections -ffunction-sections -g -Werror -Wall -Wextra -Winit-self -Wpointer-arith -Wsign-compare -Wvla -Wno-deprecated-declarations -Wno-maybe-uninitialized -Wno-extra-semi-stmt -Weverything -Wno-unknown-warning-option -Wno-anon-enum-enum-conversion -Wno-sizeof-array-div -Wno-nonportable-include-path -Wno-nonportable-system-include-path -Wno-cast-align -Wno-cast-qual -Wno-conversion -Wno-disabled-macro-expansion -Wno-documentation -Wno-documentation-unknown-command -Wno-double-promotion -Wno-exit-time-destructors -Wno-float-equal -Wno-format-nonliteral -Wno-global-constructors -Wno-missing-prototypes -Wno-missing-variable-declarations -Wno-pedantic -Wno-reserved-id-macro -Wno-shadow -Wno-shift-sign-overflow -Wno-signed-enum-bitfield -Wno-switch-enum -Wno-undef -Wno-unreachable-code -Wno-unreachable-code-break -Wno-unreachable-code-return -Wno-unused-macros -Wno-unused-member-function -Wno-unused-template -Wno-zero-as-null-pointer-constant -Wno-bad-function-cast -Wno-covered-switch-default -Wno-deprecated -Wno-missing-noreturn -Wno-old-style-cast -Wno-padded -Wno-newline-eof -Wno-implicit-fallthrough -Wno-unused-parameter -I/home/despairblue/.esy/3_____________________________________________________________/i/esy_libjpeg_turbo-e4385a3b/include -Wno-poison-system-directories -std=c++11 -fvisibility-inlines-hidden -fno-exceptions -fno-rtti -Wnon-virtual-dtor -Wno-noexcept-type -Wno-abstract-vbase-init -Wno-weak-vtables -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undefined-func-template -c ../../src/opts/SkOpts_avx.cpp -o obj/src/opts/avx.SkOpts_avx.o
    In file included from ../../src/opts/SkOpts_avx.cpp:11:
    ../../src/opts/SkRasterPipeline_opts.h:1688:15: error: AVX vector return of type 'V<unsigned long>' (vector of 8 'unsigned long' values) without 'avx512f' enabled changes the ABI [-Werror,-Wpsabi]
        auto px = gather(ptr, ix);
                  ^
    1 error generated.
    [16/1206] compile ../../src/effects/SkAlphaThresholdFilter.cpp
    FAILED: obj/src/effects/effects.SkAlphaThresholdFilter.o 
    clang++ -MMD -MF obj/src/effects/effects.SkAlphaThresholdFilter.o.d -DNDEBUG -DSK_SAMPLES_FOR_X -DSK_GAMMA_APPLY_TO_A8 -DSK_ENABLE_DISCRETE_GPU -DGR_TEST_UTILS=1 -DSKIA_IMPLEMENTATION=1 -I../../include/android -I../../include/c -I../../include/codec -I../../include/config -I../../include/core -I../../include/effects -I../../include/encode -I../../include/gpu -I../../include/atlastext -I../../include/pathops -I../../include/ports -I../../include/svg -I../../include/utils -I../../include/utils/mac -I../../include/private -I../../src/c -I../../src/codec -I../../src/core -I../../src/effects -I../../src/fonts -I../../src/image -I../../src/images -I../../src/lazy -I../../src/opts -I../../src/pathops -I../../src/pdf -I../../src/ports -I../../src/sfnt -I../../src/shaders -I../../src/shaders/gradients -I../../src/sksl -I../../src/utils -I../../src/utils/win -I../../src/xml -I../../third_party/gif -I../../src/gpu -fstrict-aliasing -fPIC -fvisibility=hidden -O3 -fdata-sections -ffunction-sections -g -Werror -Wall -Wextra -Winit-self -Wpointer-arith -Wsign-compare -Wvla -Wno-deprecated-declarations -Wno-maybe-uninitialized -Wno-extra-semi-stmt -Weverything -Wno-unknown-warning-option -Wno-anon-enum-enum-conversion -Wno-sizeof-array-div -Wno-nonportable-include-path -Wno-nonportable-system-include-path -Wno-cast-align -Wno-cast-qual -Wno-conversion -Wno-disabled-macro-expansion -Wno-documentation -Wno-documentation-unknown-command -Wno-double-promotion -Wno-exit-time-destructors -Wno-float-equal -Wno-format-nonliteral -Wno-global-constructors -Wno-missing-prototypes -Wno-missing-variable-declarations -Wno-pedantic -Wno-reserved-id-macro -Wno-shadow -Wno-shift-sign-overflow -Wno-signed-enum-bitfield -Wno-switch-enum -Wno-undef -Wno-unreachable-code -Wno-unreachable-code-break -Wno-unreachable-code-return -Wno-unused-macros -Wno-unused-member-function -Wno-unused-template -Wno-zero-as-null-pointer-constant -Wno-bad-function-cast -Wno-covered-switch-default -Wno-deprecated -Wno-missing-noreturn -Wno-old-style-cast -Wno-padded -Wno-newline-eof -Wno-implicit-fallthrough -Wno-unused-parameter -I/home/despairblue/.esy/3_____________________________________________________________/i/esy_libjpeg_turbo-e4385a3b/include -Wno-poison-system-directories -std=c++11 -fvisibility-inlines-hidden -fno-exceptions -fno-rtti -Wnon-virtual-dtor -Wno-noexcept-type -Wno-abstract-vbase-init -Wno-weak-vtables -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undefined-func-template -c ../../src/effects/SkAlphaThresholdFilter.cpp -o obj/src/effects/effects.SkAlphaThresholdFilter.o
    In file included from ../../src/effects/SkAlphaThresholdFilter.cpp:13:
    In file included from ../../src/core/SkReadBuffer.h:12:
    In file included from ../../include/core/SkSerialProcs.h:13:
    ../../include/core/SkTypeface.h:304:13: error: '~SkTypeface' overrides a destructor but is not marked 'override' [-Werror,-Wsuggest-destructor-override]
        virtual ~SkTypeface();
                ^
    ../../include/core/../private/SkWeakRefCnt.h:63:5: note: overridden virtual function is here
        ~SkWeakRefCnt() override {
        ^
    In file included from ../../src/effects/SkAlphaThresholdFilter.cpp:19:
    In file included from ../../src/gpu/GrColorSpaceXform.h:12:
    In file included from ../../src/gpu/GrFragmentProcessor.h:11:
    In file included from ../../src/gpu/GrProcessor.h:15:
    In file included from ../../src/gpu/GrProcessorUnitTest.h:15:
    In file included from ../../include/android/../private/GrTextureProxy.h:12:
    ../../include/private/GrSurfaceProxy.h:399:13: error: '~GrSurfaceProxy' overrides a destructor but is not marked 'override' [-Werror,-Wsuggest-destructor-override]
        virtual ~GrSurfaceProxy();
                ^
    ../../include/private/GrSurfaceProxy.h:149:13: note: overridden virtual function is here
        virtual ~GrIORefProxy() {
                ^
    In file included from ../../src/effects/SkAlphaThresholdFilter.cpp:20:
    ../../include/gpu/GrContext.h:89:13: error: '~GrContext' overrides a destructor but is not marked 'override' [-Werror,-Wsuggest-destructor-override]
        virtual ~GrContext();
                ^
    ../../include/core/SkRefCnt.h:127:14: note: overridden virtual function is here
    class SK_API SkRefCnt : public SkRefCntBase {
                 ^
    In file included from ../../src/effects/SkAlphaThresholdFilter.cpp:20:
    ../../include/gpu/GrContext.h:367:5: error: '~GrContextThreadSafeProxy' overrides a destructor but is not marked 'override' [-Werror,-Wsuggest-destructor-override]
        ~GrContextThreadSafeProxy();
        ^
    ../../include/core/SkRefCnt.h:127:14: note: overridden virtual function is here
    class SK_API SkRefCnt : public SkRefCntBase {
                 ^
    In file included from ../../src/effects/SkAlphaThresholdFilter.cpp:21:
    In file included from ../../src/gpu/GrFixedClip.h:11:
    In file included from ../../src/gpu/GrClip.h:12:
    In file included from ../../src/gpu/GrRenderTargetContext.h:14:
    In file included from ../../src/gpu/GrContextPriv.h:13:
    In file included from ../../src/gpu/text/GrAtlasManager.h:11:
    In file included from ../../src/gpu/GrDrawOpAtlas.h:15:
    In file included from ../../src/gpu/ops/GrDrawOp.h:14:
    In file included from ../../src/gpu/GrPipeline.h:16:
    In file included from ../../src/gpu/GrProgramDesc.h:15:
    ../../src/gpu/glsl/GrGLSLFragmentShaderBuilder.h:25:13: error: '~GrGLSLFragmentBuilder' overrides a destructor but is not marked 'override' [-Werror,-Wsuggest-destructor-override]
        virtual ~GrGLSLFragmentBuilder() {}
                ^
    ../../src/gpu/glsl/GrGLSLShaderBuilder.h:26:13: note: overridden virtual function is here
        virtual ~GrGLSLShaderBuilder() {}
                ^
    5 errors generated.
    [17/1206] compile ../../src/effects/SkArithmeticImageFilter.cpp
    FAILED: obj/src/effects/effects.SkArithmeticImageFilter.o 
    clang++ -MMD -MF obj/src/effects/effects.SkArithmeticImageFilter.o.d -DNDEBUG -DSK_SAMPLES_FOR_X -DSK_GAMMA_APPLY_TO_A8 -DSK_ENABLE_DISCRETE_GPU -DGR_TEST_UTILS=1 -DSKIA_IMPLEMENTATION=1 -I../../include/android -I../../include/c -I../../include/codec -I../../include/config -I../../include/core -I../../include/effects -I../../include/encode -I../../include/gpu -I../../include/atlastext -I../../include/pathops -I../../include/ports -I../../include/svg -I../../include/utils -I../../include/utils/mac -I../../include/private -I../../src/c -I../../src/codec -I../../src/core -I../../src/effects -I../../src/fonts -I../../src/image -I../../src/images -I../../src/lazy -I../../src/opts -I../../src/pathops -I../../src/pdf -I../../src/ports -I../../src/sfnt -I../../src/shaders -I../../src/shaders/gradients -I../../src/sksl -I../../src/utils -I../../src/utils/win -I../../src/xml -I../../third_party/gif -I../../src/gpu -fstrict-aliasing -fPIC -fvisibility=hidden -O3 -fdata-sections -ffunction-sections -g -Werror -Wall -Wextra -Winit-self -Wpointer-arith -Wsign-compare -Wvla -Wno-deprecated-declarations -Wno-maybe-uninitialized -Wno-extra-semi-stmt -Weverything -Wno-unknown-warning-option -Wno-anon-enum-enum-conversion -Wno-sizeof-array-div -Wno-nonportable-include-path -Wno-nonportable-system-include-path -Wno-cast-align -Wno-cast-qual -Wno-conversion -Wno-disabled-macro-expansion -Wno-documentation -Wno-documentation-unknown-command -Wno-double-promotion -Wno-exit-time-destructors -Wno-float-equal -Wno-format-nonliteral -Wno-global-constructors -Wno-missing-prototypes -Wno-missing-variable-declarations -Wno-pedantic -Wno-reserved-id-macro -Wno-shadow -Wno-shift-sign-overflow -Wno-signed-enum-bitfield -Wno-switch-enum -Wno-undef -Wno-unreachable-code -Wno-unreachable-code-break -Wno-unreachable-code-return -Wno-unused-macros -Wno-unused-member-function -Wno-unused-template -Wno-zero-as-null-pointer-constant -Wno-bad-function-cast -Wno-covered-switch-default -Wno-deprecated -Wno-missing-noreturn -Wno-old-style-cast -Wno-padded -Wno-newline-eof -Wno-implicit-fallthrough -Wno-unused-parameter -I/home/despairblue/.esy/3_____________________________________________________________/i/esy_libjpeg_turbo-e4385a3b/include -Wno-poison-system-directories -std=c++11 -fvisibility-inlines-hidden -fno-exceptions -fno-rtti -Wnon-virtual-dtor -Wno-noexcept-type -Wno-abstract-vbase-init -Wno-weak-vtables -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undefined-func-template -c ../../src/effects/SkArithmeticImageFilter.cpp -o obj/src/effects/effects.SkArithmeticImageFilter.o
    In file included from ../../src/effects/SkArithmeticImageFilter.cpp:13:
    In file included from ../../src/core/SkReadBuffer.h:12:
    In file included from ../../include/core/SkSerialProcs.h:13:
    ../../include/core/SkTypeface.h:304:13: error: '~SkTypeface' overrides a destructor but is not marked 'override' [-Werror,-Wsuggest-destructor-override]
        virtual ~SkTypeface();
                ^
    ../../include/core/../private/SkWeakRefCnt.h:63:5: note: overridden virtual function is here
        ~SkWeakRefCnt() override {
        ^
    In file included from ../../src/effects/SkArithmeticImageFilter.cpp:19:
    In file included from ../../src/gpu/GrClip.h:11:
    In file included from ../../src/gpu/GrAppliedClip.h:11:
    In file included from ../../src/gpu/GrFragmentProcessor.h:11:
    In file included from ../../src/gpu/GrProcessor.h:15:
    In file included from ../../src/gpu/GrProcessorUnitTest.h:15:
    In file included from ../../include/android/../private/GrTextureProxy.h:12:
    ../../include/private/GrSurfaceProxy.h:399:13: error: '~GrSurfaceProxy' overrides a destructor but is not marked 'override' [-Werror,-Wsuggest-destructor-override]
        virtual ~GrSurfaceProxy();
                ^
    ../../include/private/GrSurfaceProxy.h:149:13: note: overridden virtual function is here
        virtual ~GrIORefProxy() {
                ^
    In file included from ../../src/effects/SkArithmeticImageFilter.cpp:19:
    In file included from ../../src/gpu/GrClip.h:12:
    In file included from ../../src/gpu/GrRenderTargetContext.h:13:
    ../../include/gpu/GrContext.h:89:13: error: '~GrContext' overrides a destructor but is not marked 'override' [-Werror,-Wsuggest-destructor-override]
        virtual ~GrContext();
                ^
    ../../include/core/SkRefCnt.h:127:14: note: overridden virtual function is here
    class SK_API SkRefCnt : public SkRefCntBase {
                 ^
    In file included from ../../src/effects/SkArithmeticImageFilter.cpp:19:
    In file included from ../../src/gpu/GrClip.h:12:
    In file included from ../../src/gpu/GrRenderTargetContext.h:13:
    ../../include/gpu/GrContext.h:367:5: error: '~GrContextThreadSafeProxy' overrides a destructor but is not marked 'override' [-Werror,-Wsuggest-destructor-override]
        ~GrContextThreadSafeProxy();
        ^
    ../../include/core/SkRefCnt.h:127:14: note: overridden virtual function is here
    class SK_API SkRefCnt : public SkRefCntBase {
                 ^
    In file included from ../../src/effects/SkArithmeticImageFilter.cpp:19:
    In file included from ../../src/gpu/GrClip.h:12:
    In file included from ../../src/gpu/GrRenderTargetContext.h:14:
    In file included from ../../src/gpu/GrContextPriv.h:13:
    In file included from ../../src/gpu/text/GrAtlasManager.h:11:
    In file included from ../../src/gpu/GrDrawOpAtlas.h:15:
    In file included from ../../src/gpu/ops/GrDrawOp.h:14:
    In file included from ../../src/gpu/GrPipeline.h:16:
    In file included from ../../src/gpu/GrProgramDesc.h:15:
    ../../src/gpu/glsl/GrGLSLFragmentShaderBuilder.h:25:13: error: '~GrGLSLFragmentBuilder' overrides a destructor but is not marked 'override' [-Werror,-Wsuggest-destructor-override]
        virtual ~GrGLSLFragmentBuilder() {}
                ^
    ../../src/gpu/glsl/GrGLSLShaderBuilder.h:26:13: note: overridden virtual function is here
        virtual ~GrGLSLShaderBuilder() {}
                ^
    5 errors generated.
    ninja: build stopped: subcommand failed.
    error: command failed: 'bash' './esy/build.sh' 'linux' '/home/despairblue/.esy/3_____________________________________________________________/i/esy_libjpeg_turbo-e4385a3b' (exited with 1)
    esy-build-package: exiting with errors above...
    
  building esy-skia@github:revery-ui/esy-skia#60e0260
esy: exiting due to errors above


</details>

despairblue avatar Sep 25 '21 21:09 despairblue

I think the build error was fixed in revery here: https://github.com/revery-ui/revery/pull/1033

despairblue avatar Sep 25 '21 21:09 despairblue

I upgraded revery in the resolutions of the package.json to 14402ad200a6c659afa67315b7fe36cdb1c5ef3c but it still fails with the same errors.

despairblue avatar Sep 25 '21 22:09 despairblue

Can you try this branch https://github.com/revery-ui/esy-skia/tree/fix-oni2-3824

Et7f3 avatar Sep 25 '21 23:09 Et7f3

Just tried only with overriding esy-skia like this:

        "esy-skia": "revery-ui/esy-skia#a1c5de7b1a1bc0a6eadabdefc7cee338d29748e8",

Which still failed, now I try overriding revery and esy-skia like this:

        "revery": "revery-ui/revery#14402ad200a6c659afa67315b7fe36cdb1c5ef3c",
        "esy-skia": "revery-ui/esy-skia#a1c5de7b1a1bc0a6eadabdefc7cee338d29748e8",

despairblue avatar Sep 26 '21 07:09 despairblue

Same, I think I have to go into esy_libjpeg_turbo and have to fix it there too. I'll try that.

despairblue avatar Sep 26 '21 07:09 despairblue

So I still get this:

Details
info building esy-skia@github:revery-ui/esy-skia#a1c5de7b1a1bc0a6eadabdefc7cee338d29748e8@d41d8cd9
error: build failed with exit code: 1
  build log:
    # esy-build-package: building: esy-skia@github:revery-ui/esy-skia#a1c5de7b1a1bc0a6eadabdefc7cee338d29748e8
    # esy-build-package: pwd: /home/despairblue/.esy/3/b/esy_skia-894eea68
    # esy-build-package: running: 'bash' './esy/build.sh' 'linux' '/home/despairblue/.esy/3_____________________________________________________________/i/esy_libjpeg_turbo-e4385a3b'
    buildtools                           @ 505de88083136eefd056e5ee4ca0f01fe9b33de8
    third_party/externals/angle2         @ b001528ffa00e7c15a5002124f707570e59a5697
    third_party/externals/dng_sdk        @ 96443b262250c390b0caefbf3eed8463ba35ecae
    third_party/externals/expat          @ android-6.0.1_r55
    third_party/externals/freetype       @ fa6da7bf6dcbcfa22d2464259ad1cccee3233189
    third_party/externals/googletest     @ dd43b9998e9a44a579a7aba6c1309407d1a5ed95
    third_party/externals/harfbuzz       @ 1.4.2
    third_party/externals/icu            @ ec9c1133693148470ffe2e5e53576998e3650c1d
    third_party/externals/imgui          @ 6384eee34f08cb7eab8d835043e1738e4adcdf75
    third_party/externals/jsoncpp        @ 1.0.0
    third_party/externals/libjpeg-turbo  @ 1.5.3
    third_party/externals/libpng         @ v1.6.33
    third_party/externals/libwebp        @ v0.6.1
    third_party/externals/lua            @ v5-3-4
    third_party/externals/microhttpd     @ 748945ec6f1c67b7efc934ab0808e1d32f2fb98d
    third_party/externals/piex           @ bb217acdca1cc0c16b704669dd6f91a1b509c406
    third_party/externals/rapidjson      @ af223d44f4e8d3772cb1ac0ce8bc2a132b51717f
    third_party/externals/sdl            @ 5d7cfcca344034aff9327f77fc181ae3754e7a90
    third_party/externals/sfntly         @ b18b09b6114b9b7fe6fc2f96d8b15e8a72f66916
    third_party/externals/spirv-headers  @ 661ad91124e6af2272afd00f804d8aa276e17107
    third_party/externals/spirv-tools    @ e9e4393b1c5aad7553c05782acefbe32b42644bd
    third_party/externals/swiftshader    @ cbb80f5f0078a9941f3ec43e83e52c3d15a43bea
    third_party/externals/zlib           @ e7afdfe128e01ca480a28f757b571957befdd962
    llvm toolset-7.0 does not need to be manually activated
    Done. Made 45 targets from 27 files in 34ms
    ninja: Entering directory `/home/despairblue/.esy/3/b/esy_skia-894eea68/out/Static'
    [1/1230] stamp obj/arm64.stamp
    [2/1230] stamp obj/armv7.stamp
    [3/1230] stamp obj/compile_processors.stamp
    [4/1230] stamp obj/crc32.stamp
    [5/1230] compile ../../src/effects/SkColorMatrix.cpp
    [6/1230] compile ../../src/effects/Sk1DPathEffect.cpp
    [7/1230] compile ../../src/ports/SkFontConfigInterface_direct.cpp
    [8/1230] stamp obj/fontmgr_custom.stamp
    [9/1230] stamp obj/fontmgr_empty.stamp
    [10/1230] compile ../../src/effects/SkColorFilterImageFilter.cpp
    [11/1230] compile ../../src/gpu/GrPaint.cpp
    FAILED: obj/src/gpu/gpu.GrPaint.o 
    clang++ -MMD -MF obj/src/gpu/gpu.GrPaint.o.d -DNDEBUG -DSK_SAMPLES_FOR_X -DSK_GAMMA_APPLY_TO_A8 -DSK_ENABLE_DISCRETE_GPU -DGR_TEST_UTILS=1 -DSKIA_IMPLEMENTATION=1 -I../../include/android -I../../include/c -I../../include/codec -I../../include/config -I../../include/core -I../../include/effects -I../../include/encode -I../../include/gpu -I../../include/atlastext -I../../include/pathops -I../../include/ports -I../../include/svg -I../../include/utils -I../../include/utils/mac -I../../include/private -I../../src/c -I../../src/codec -I../../src/core -I../../src/effects -I../../src/fonts -I../../src/image -I../../src/images -I../../src/lazy -I../../src/opts -I../../src/pathops -I../../src/pdf -I../../src/ports -I../../src/sfnt -I../../src/shaders -I../../src/shaders/gradients -I../../src/sksl -I../../src/utils -I../../src/utils/win -I../../src/xml -I../../third_party/gif -I../../experimental/svg/model -I../../src/gpu -fstrict-aliasing -fPIC -fvisibility=hidden -O3 -fdata-sections -ffunction-sections -g -Werror -Wall -Wextra -Winit-self -Wpointer-arith -Wsign-compare -Wvla -Wno-deprecated-declarations -Wno-maybe-uninitialized -Wno-extra-semi-stmt -Weverything -Wno-unknown-warning-option -Wno-anon-enum-enum-conversion -Wno-sizeof-array-div -Wno-psabi -Wno-suggest-destructor-override -Wno-suggest-override -Wno-uninitialized-const-reference -Wno-poison-system-directories -Wno-nonportable-include-path -Wno-nonportable-system-include-path -Wno-cast-align -Wno-cast-qual -Wno-conversion -Wno-disabled-macro-expansion -Wno-documentation -Wno-documentation-unknown-command -Wno-double-promotion -Wno-exit-time-destructors -Wno-float-equal -Wno-format-nonliteral -Wno-global-constructors -Wno-missing-prototypes -Wno-missing-variable-declarations -Wno-pedantic -Wno-reserved-id-macro -Wno-shadow -Wno-shift-sign-overflow -Wno-signed-enum-bitfield -Wno-switch-enum -Wno-undef -Wno-unreachable-code -Wno-unreachable-code-break -Wno-unreachable-code-return -Wno-unused-macros -Wno-unused-member-function -Wno-unused-template -Wno-zero-as-null-pointer-constant -Wno-bad-function-cast -Wno-covered-switch-default -Wno-deprecated -Wno-missing-noreturn -Wno-old-style-cast -Wno-padded -Wno-newline-eof -Wno-implicit-fallthrough -Wno-unused-parameter -I/home/despairblue/.esy/3_____________________________________________________________/i/esy_libjpeg_turbo-e4385a3b/include -std=c++11 -fvisibility-inlines-hidden -fno-exceptions -fno-rtti -Wnon-virtual-dtor -Wno-noexcept-type -Wno-abstract-vbase-init -Wno-weak-vtables -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undefined-func-template -c ../../src/gpu/GrPaint.cpp -o obj/src/gpu/gpu.GrPaint.o
    In file included from ../../src/gpu/GrPaint.cpp:8:
    In file included from ../../src/gpu/GrPaint.h:14:
    In file included from ../../src/gpu/GrFragmentProcessor.h:11:
    In file included from ../../src/gpu/GrProcessor.h:15:
    In file included from ../../src/gpu/GrProcessorUnitTest.h:15:
    In file included from ../../include/android/../private/GrTextureProxy.h:12:
    ../../include/private/GrSurfaceProxy.h:149:13: error: '~GrIORefProxy' marked 'override' but does not override any member functions
        virtual ~GrIORefProxy() override {
                ^
    1 error generated.
    [12/1230] compile ../../src/effects/Sk2DPathEffect.cpp
    [13/1230] compile ../../src/ports/SkFontConfigInterface_direct_factory.cpp
    [14/1230] compile ../../src/ports/SkFontConfigInterface.cpp
    [15/1230] compile ../../src/ports/SkFontMgr_fontconfig_factory.cpp
    [16/1230] compile ../../src/gpu/GrPath.cpp
    FAILED: obj/src/gpu/gpu.GrPath.o 
    clang++ -MMD -MF obj/src/gpu/gpu.GrPath.o.d -DNDEBUG -DSK_SAMPLES_FOR_X -DSK_GAMMA_APPLY_TO_A8 -DSK_ENABLE_DISCRETE_GPU -DGR_TEST_UTILS=1 -DSKIA_IMPLEMENTATION=1 -I../../include/android -I../../include/c -I../../include/codec -I../../include/config -I../../include/core -I../../include/effects -I../../include/encode -I../../include/gpu -I../../include/atlastext -I../../include/pathops -I../../include/ports -I../../include/svg -I../../include/utils -I../../include/utils/mac -I../../include/private -I../../src/c -I../../src/codec -I../../src/core -I../../src/effects -I../../src/fonts -I../../src/image -I../../src/images -I../../src/lazy -I../../src/opts -I../../src/pathops -I../../src/pdf -I../../src/ports -I../../src/sfnt -I../../src/shaders -I../../src/shaders/gradients -I../../src/sksl -I../../src/utils -I../../src/utils/win -I../../src/xml -I../../third_party/gif -I../../experimental/svg/model -I../../src/gpu -fstrict-aliasing -fPIC -fvisibility=hidden -O3 -fdata-sections -ffunction-sections -g -Werror -Wall -Wextra -Winit-self -Wpointer-arith -Wsign-compare -Wvla -Wno-deprecated-declarations -Wno-maybe-uninitialized -Wno-extra-semi-stmt -Weverything -Wno-unknown-warning-option -Wno-anon-enum-enum-conversion -Wno-sizeof-array-div -Wno-psabi -Wno-suggest-destructor-override -Wno-suggest-override -Wno-uninitialized-const-reference -Wno-poison-system-directories -Wno-nonportable-include-path -Wno-nonportable-system-include-path -Wno-cast-align -Wno-cast-qual -Wno-conversion -Wno-disabled-macro-expansion -Wno-documentation -Wno-documentation-unknown-command -Wno-double-promotion -Wno-exit-time-destructors -Wno-float-equal -Wno-format-nonliteral -Wno-global-constructors -Wno-missing-prototypes -Wno-missing-variable-declarations -Wno-pedantic -Wno-reserved-id-macro -Wno-shadow -Wno-shift-sign-overflow -Wno-signed-enum-bitfield -Wno-switch-enum -Wno-undef -Wno-unreachable-code -Wno-unreachable-code-break -Wno-unreachable-code-return -Wno-unused-macros -Wno-unused-member-function -Wno-unused-template -Wno-zero-as-null-pointer-constant -Wno-bad-function-cast -Wno-covered-switch-default -Wno-deprecated -Wno-missing-noreturn -Wno-old-style-cast -Wno-padded -Wno-newline-eof -Wno-implicit-fallthrough -Wno-unused-parameter -I/home/despairblue/.esy/3_____________________________________________________________/i/esy_libjpeg_turbo-e4385a3b/include -std=c++11 -fvisibility-inlines-hidden -fno-exceptions -fno-rtti -Wnon-virtual-dtor -Wno-noexcept-type -Wno-abstract-vbase-init -Wno-weak-vtables -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undefined-func-template -c ../../src/gpu/GrPath.cpp -o obj/src/gpu/gpu.GrPath.o
    In file included from ../../src/gpu/GrPath.cpp:8:
    In file included from ../../src/gpu/GrPath.h:12:
    In file included from ../../src/gpu/GrPathRendering.h:12:
    In file included from ../../src/gpu/GrPipeline.h:12:
    In file included from ../../src/gpu/GrFragmentProcessor.h:11:
    In file included from ../../src/gpu/GrProcessor.h:15:
    In file included from ../../src/gpu/GrProcessorUnitTest.h:15:
    In file included from ../../include/android/../private/GrTextureProxy.h:12:
    ../../include/private/GrSurfaceProxy.h:149:13: error: '~GrIORefProxy' marked 'override' but does not override any member functions
        virtual ~GrIORefProxy() override {
                ^
    1 error generated.
    [17/1230] compile ../../src/effects/SkAlphaThresholdFilter.cpp
    FAILED: obj/src/effects/effects.SkAlphaThresholdFilter.o 
    clang++ -MMD -MF obj/src/effects/effects.SkAlphaThresholdFilter.o.d -DNDEBUG -DSK_SAMPLES_FOR_X -DSK_GAMMA_APPLY_TO_A8 -DSK_ENABLE_DISCRETE_GPU -DGR_TEST_UTILS=1 -DSKIA_IMPLEMENTATION=1 -I../../include/android -I../../include/c -I../../include/codec -I../../include/config -I../../include/core -I../../include/effects -I../../include/encode -I../../include/gpu -I../../include/atlastext -I../../include/pathops -I../../include/ports -I../../include/svg -I../../include/utils -I../../include/utils/mac -I../../include/private -I../../src/c -I../../src/codec -I../../src/core -I../../src/effects -I../../src/fonts -I../../src/image -I../../src/images -I../../src/lazy -I../../src/opts -I../../src/pathops -I../../src/pdf -I../../src/ports -I../../src/sfnt -I../../src/shaders -I../../src/shaders/gradients -I../../src/sksl -I../../src/utils -I../../src/utils/win -I../../src/xml -I../../third_party/gif -I../../experimental/svg/model -I../../src/gpu -fstrict-aliasing -fPIC -fvisibility=hidden -O3 -fdata-sections -ffunction-sections -g -Werror -Wall -Wextra -Winit-self -Wpointer-arith -Wsign-compare -Wvla -Wno-deprecated-declarations -Wno-maybe-uninitialized -Wno-extra-semi-stmt -Weverything -Wno-unknown-warning-option -Wno-anon-enum-enum-conversion -Wno-sizeof-array-div -Wno-psabi -Wno-suggest-destructor-override -Wno-suggest-override -Wno-uninitialized-const-reference -Wno-poison-system-directories -Wno-nonportable-include-path -Wno-nonportable-system-include-path -Wno-cast-align -Wno-cast-qual -Wno-conversion -Wno-disabled-macro-expansion -Wno-documentation -Wno-documentation-unknown-command -Wno-double-promotion -Wno-exit-time-destructors -Wno-float-equal -Wno-format-nonliteral -Wno-global-constructors -Wno-missing-prototypes -Wno-missing-variable-declarations -Wno-pedantic -Wno-reserved-id-macro -Wno-shadow -Wno-shift-sign-overflow -Wno-signed-enum-bitfield -Wno-switch-enum -Wno-undef -Wno-unreachable-code -Wno-unreachable-code-break -Wno-unreachable-code-return -Wno-unused-macros -Wno-unused-member-function -Wno-unused-template -Wno-zero-as-null-pointer-constant -Wno-bad-function-cast -Wno-covered-switch-default -Wno-deprecated -Wno-missing-noreturn -Wno-old-style-cast -Wno-padded -Wno-newline-eof -Wno-implicit-fallthrough -Wno-unused-parameter -I/home/despairblue/.esy/3_____________________________________________________________/i/esy_libjpeg_turbo-e4385a3b/include -std=c++11 -fvisibility-inlines-hidden -fno-exceptions -fno-rtti -Wnon-virtual-dtor -Wno-noexcept-type -Wno-abstract-vbase-init -Wno-weak-vtables -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undefined-func-template -c ../../src/effects/SkAlphaThresholdFilter.cpp -o obj/src/effects/effects.SkAlphaThresholdFilter.o
    In file included from ../../src/effects/SkAlphaThresholdFilter.cpp:19:
    In file included from ../../src/gpu/GrColorSpaceXform.h:12:
    In file included from ../../src/gpu/GrFragmentProcessor.h:11:
    In file included from ../../src/gpu/GrProcessor.h:15:
    In file included from ../../src/gpu/GrProcessorUnitTest.h:15:
    In file included from ../../include/android/../private/GrTextureProxy.h:12:
    ../../include/private/GrSurfaceProxy.h:149:13: error: '~GrIORefProxy' marked 'override' but does not override any member functions
        virtual ~GrIORefProxy() override {
                ^
    1 error generated.
    [18/1230] compile ../../src/ports/SkFontMgr_fontconfig.cpp
    [19/1230] compile ../../src/effects/SkArithmeticImageFilter.cpp
    FAILED: obj/src/effects/effects.SkArithmeticImageFilter.o 
    clang++ -MMD -MF obj/src/effects/effects.SkArithmeticImageFilter.o.d -DNDEBUG -DSK_SAMPLES_FOR_X -DSK_GAMMA_APPLY_TO_A8 -DSK_ENABLE_DISCRETE_GPU -DGR_TEST_UTILS=1 -DSKIA_IMPLEMENTATION=1 -I../../include/android -I../../include/c -I../../include/codec -I../../include/config -I../../include/core -I../../include/effects -I../../include/encode -I../../include/gpu -I../../include/atlastext -I../../include/pathops -I../../include/ports -I../../include/svg -I../../include/utils -I../../include/utils/mac -I../../include/private -I../../src/c -I../../src/codec -I../../src/core -I../../src/effects -I../../src/fonts -I../../src/image -I../../src/images -I../../src/lazy -I../../src/opts -I../../src/pathops -I../../src/pdf -I../../src/ports -I../../src/sfnt -I../../src/shaders -I../../src/shaders/gradients -I../../src/sksl -I../../src/utils -I../../src/utils/win -I../../src/xml -I../../third_party/gif -I../../experimental/svg/model -I../../src/gpu -fstrict-aliasing -fPIC -fvisibility=hidden -O3 -fdata-sections -ffunction-sections -g -Werror -Wall -Wextra -Winit-self -Wpointer-arith -Wsign-compare -Wvla -Wno-deprecated-declarations -Wno-maybe-uninitialized -Wno-extra-semi-stmt -Weverything -Wno-unknown-warning-option -Wno-anon-enum-enum-conversion -Wno-sizeof-array-div -Wno-psabi -Wno-suggest-destructor-override -Wno-suggest-override -Wno-uninitialized-const-reference -Wno-poison-system-directories -Wno-nonportable-include-path -Wno-nonportable-system-include-path -Wno-cast-align -Wno-cast-qual -Wno-conversion -Wno-disabled-macro-expansion -Wno-documentation -Wno-documentation-unknown-command -Wno-double-promotion -Wno-exit-time-destructors -Wno-float-equal -Wno-format-nonliteral -Wno-global-constructors -Wno-missing-prototypes -Wno-missing-variable-declarations -Wno-pedantic -Wno-reserved-id-macro -Wno-shadow -Wno-shift-sign-overflow -Wno-signed-enum-bitfield -Wno-switch-enum -Wno-undef -Wno-unreachable-code -Wno-unreachable-code-break -Wno-unreachable-code-return -Wno-unused-macros -Wno-unused-member-function -Wno-unused-template -Wno-zero-as-null-pointer-constant -Wno-bad-function-cast -Wno-covered-switch-default -Wno-deprecated -Wno-missing-noreturn -Wno-old-style-cast -Wno-padded -Wno-newline-eof -Wno-implicit-fallthrough -Wno-unused-parameter -I/home/despairblue/.esy/3_____________________________________________________________/i/esy_libjpeg_turbo-e4385a3b/include -std=c++11 -fvisibility-inlines-hidden -fno-exceptions -fno-rtti -Wnon-virtual-dtor -Wno-noexcept-type -Wno-abstract-vbase-init -Wno-weak-vtables -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undefined-func-template -c ../../src/effects/SkArithmeticImageFilter.cpp -o obj/src/effects/effects.SkArithmeticImageFilter.o
    In file included from ../../src/effects/SkArithmeticImageFilter.cpp:19:
    In file included from ../../src/gpu/GrClip.h:11:
    In file included from ../../src/gpu/GrAppliedClip.h:11:
    In file included from ../../src/gpu/GrFragmentProcessor.h:11:
    In file included from ../../src/gpu/GrProcessor.h:15:
    In file included from ../../src/gpu/GrProcessorUnitTest.h:15:
    In file included from ../../include/android/../private/GrTextureProxy.h:12:
    ../../include/private/GrSurfaceProxy.h:149:13: error: '~GrIORefProxy' marked 'override' but does not override any member functions
        virtual ~GrIORefProxy() override {
                ^
    1 error generated.
    [20/1230] compile ../../src/opts/SkOpts_avx.cpp
    ninja: build stopped: subcommand failed.
    error: command failed: 'bash' './esy/build.sh' 'linux' '/home/despairblue/.esy/3_____________________________________________________________/i/esy_libjpeg_turbo-e4385a3b' (exited with 255)
    esy-build-package: exiting with errors above...
    
  building esy-skia@github:revery-ui/esy-skia#a1c5de7b1a1bc0a6eadabdefc7cee338d29748e8
esy: exiting due to errors above

I cloned https://github.com/revery-ui/libjpeg-turbo/ now and try to find the file GrTextureProxy.h, but can't find it. I'm probably looking in the wrong place 🤔

despairblue avatar Sep 26 '21 08:09 despairblue

Is it possible this error comes from code generation and I would need to understand skia or libjpeg to figure out where the error comes from in the source?

despairblue avatar Sep 26 '21 08:09 despairblue

Oh, the error is actually different, before it was complaining about it overriding the other thing without being marked as such, now it complains about overriding the other thing but not overriding member functions...

despairblue avatar Sep 26 '21 08:09 despairblue

I didn't see a way to fix this now without learning C++ and rewriting parts of skia 😄

So I forked esy-skia removed -Werror from the cflags.

despairblue avatar Sep 26 '21 09:09 despairblue

Actually disregard everything I said so far (except the binaries not working). I wasn't on the current master, my local oni repo was probably out of date for a couple of months...

With current master everything works actually.

So I guess we just need to recreate the binaries in CI with a newer glibc version installed?

despairblue avatar Sep 26 '21 09:09 despairblue

I'll try the docker build instructions to see if they produce broken binaries on my arch system. If so, I'll try to use a more recent version of centos and see if that fixes it.

despairblue avatar Sep 26 '21 09:09 despairblue

Oh, the error is actually different, before it was complaining about it overriding the other thing without being marked as such, now it complains about overriding the other thing but not overriding member functions...

I have done a monkey patch but not compiled myself mb. I expected the change to be small and pass directly. But this seem like a clang bug because now he want to remove it. Clang13 is around the corner so it might be fixed.

For another CI build maybe ask @zbaylin why do you need the docker build building directly on your arch doesn't work ?

Et7f3 avatar Sep 26 '21 10:09 Et7f3

For another CI build maybe ask @zbaylin why do you need the docker build building directly on your arch doesn't work ?

It does, I want to check though if building it on centos and running it on Arch works. If that would not work then retriggering CI to create a new nightly won't fix it, right?

My goal is to be able to run the nightlies on Arch again.

despairblue avatar Sep 26 '21 11:09 despairblue

Yeah, using the docker build process still creates a binary having this error:

/tmp/.mount_OnivimaqTmiB/usr/bin/Oni2_editor: symbol lookup error: /usr/lib/libgio-2.0.so.0: undefined symbol: g_module_open_full

I'll check if upgrading to centos 8 helps.

despairblue avatar Sep 26 '21 19:09 despairblue

Ok, no idea how to do that, install centos-release-scl is not available or not necessary anymore unter centos 8 and yum-config-manager does not exist anymore.

Would it be easier to take a newer ubuntu and compile on that one? What was the reason for choosing centos?

despairblue avatar Sep 26 '21 19:09 despairblue

What was the reason for choosing centos?

Believe it or not, there are still quite a few people stuck using CentOS 7. Some of us like to to be able to use OniVim on such systems.

I believe that the thought is that picking the oldest supported RedHat release provides a good base to cover pretty much any other distro.

t-wiser avatar Sep 27 '21 14:09 t-wiser

What was the reason for choosing centos?

Believe it or not, there are still quite a few people stuck using CentOS 7. Some of us like to to be able to use OniVim on such systems.

I believe that the thought is that picking the oldest supported RedHat release provides a good base to cover pretty much any other distro.

I guess we can have our cake and eat it too, just need to run 2 Linux pipelines, right?

despairblue avatar Sep 27 '21 16:09 despairblue

Currently when trying to compile oni in a docker container with ubuntu 20.04 I get a lot of those

relocation R_X86_64_32S against symbol `caml_data_segments' can not be used when making a PIE object; recompile with -fPIE

Anybody knows what that means?

despairblue avatar Sep 27 '21 20:09 despairblue

Nevermind that, I was sharing the build cache of my system with the docker image and that caused the issue.

despairblue avatar Sep 27 '21 20:09 despairblue

out of subject:

But this seem like a clang bug because now he want to remove it. Clang13 is around the corner so it might be fixed.

I compiled with apple clang 12 no warning and with clang quite recent (compiled from main a month ago) I can reproduce the warning. I have also removed flags: -Wno-suggest-destructor-override -Wno-suggest-override and added -Weverything

So I don't know how arch linux package clang 🤷

Et7f3 avatar Sep 27 '21 21:09 Et7f3

out of subject:

But this seem like a clang bug because now he want to remove it. Clang13 is around the corner so it might be fixed.

I compiled with apple clang 12 no warning and with clang quite recent (compiled from main a month ago) I can reproduce the warning. I have also removed flags: -Wno-suggest-destructor-override -Wno-suggest-override and added -Weverything

So I don't know how arch linux package clang 🤷

I'll check that out today.

despairblue avatar Sep 28 '21 06:09 despairblue

@Et7f3 yeah so basically what I said there is correct:

https://github.com/onivim/oni2/issues/3824#issuecomment-927273111

Everything I said about the errors related to esy-skia and clang was wrong. I just didn't git pull before building.

Sorry about the confusion.


What remains though is that the binaries generated on CentOS do not work on Arch Linux at the moment.

despairblue avatar Sep 28 '21 19:09 despairblue

Can you grep g_module_open_full in .esy to detect which dependencies require this symbol (and need to be updated)

Et7f3 avatar Sep 28 '21 19:09 Et7f3

I'll let you know when it finds something, has been running for 20 minutes now 😄

despairblue avatar Sep 28 '21 20:09 despairblue

I tried ag g_module_open_full and it could not find anything. grep g_module_open_full is still running.

despairblue avatar Sep 28 '21 20:09 despairblue

If you don't find something it means a dependencies on host library so you might also look in /lib* /usr/lib* /usr/local/lib* ...

Et7f3 avatar Sep 28 '21 21:09 Et7f3

Ah I have other idea in man ld.so I see LD_DEBUG try to export as libs and run your binary. 🤦🏻libgio require this symbol and it is absent of your machine hence the error. You can cancel.

Et7f3 avatar Sep 28 '21 21:09 Et7f3

https://forum.manjaro.org/t/vscodium-appimage-wont-launch-symbol-lookup-error-libgio/84462/3 Seem to be glibc issue 😬

Et7f3 avatar Sep 28 '21 21:09 Et7f3

forum.manjaro.org/t/vscodium-appimage-wont-launch-symbol-lookup-error-libgio/84462/3 Seem to be glibc issue grimacing

Yeah, that was my first thought since this happens from time to time with arch.

I supposed glib2 has been upgraded and is not not compatible anymore.

Having 2 binaries, one for old linux systems and one for newer systems, would solve this, right?

despairblue avatar Sep 29 '21 06:09 despairblue