Plugin Problem with alefragnani.project-manager

[iilonmasc]

Since the plugin is working in VSCode, I'm filing the issue here:

After installing the project-manager from alefragnani no sidebar entry is added and the open project command from the plugin doesn't work.

What I expected:

1. After installing the plugin, the sidebar should show the sidebar entry from the plugin
2. After configuring the project paths for the plugin the project list should show my projects (which works in onivim!)
3. Opening a project through the plugin should either open a new onivim instance with the project or replace the current opened directory with the project directory

What happens

1. After installing, no sidebar entry is added, so only calling the plugin through the command palette works (which isn't really an issue but might be an inconvenience for some).
2. Trying to use the projectManager.listProjects command either through the palette or via keybind (which has to be configured first) does not open any project.

Steps to reproduce

1. Install the plugin (through CLI!, it did not work through the plugin list in onivim) oni2 --install-extension project-manager
2. Start onivim and configure the plugin to search your projects in a specific path. In my case I used the following

"projectManager.git.baseFolders": [
    "C:\\Users\\myUser\\git-projects\\"
  ]

3. Use the command palette or a keybind to open the project list. The keybind I used is { "key": "<A-S-P>", "command": "projectManager.listProjects", "when": "normalMode"} which mirrors the VSCode behaviour.

4. Select one of your projects and try to open it with ENTER, it does not open the chosen project.

Note: Apparently the git branch detection doesn't work either because projects are listed as $(git-branch) name-of-my-project but this might also happen because of how I setup my git instance on windows.

If plugin issues with onivim should be filed against the plugin repository itself please disregard this issue though.

[bryphe]

Thanks for the great bug report @iilonmasc ! Really appreciate all the details.

Looks like there are a few issues:

Issue 1: Quick menu selection

Looks like there are a few messages that are being sent up that we are not currently handling:

[WARN]  [37.234s] Oni2.Extension.ClientStore : Unhandled message: (Msg.Commands
   Msg.Commands.ExecuteCommand {command = "setContext";
     args = [`String ("inProjectManagerList"); `Bool (true)]; retry = true})
[WARN]  [45.653s] Oni2.Extension.ClientStore : Unhandled message: (Msg.Commands
   Msg.Commands.ExecuteCommand {command = "setContext";
     args = [`String ("inProjectManagerList"); `Bool (false)]; retry = true})
[WARN]  [45.655s] Oni2.Extension.ClientStore : Unhandled message: (Msg.Commands
   Msg.Commands.ExecuteCommand {command = "vscode.openFolder";
     args =
     [`Assoc ([("$mid", `Int (1));
                ("path", `String ("/Users/bryphe/editor-core-types"));
                ("scheme", `String ("file"))]);
       `Bool (false)];
     retry = true})

Issue 2: Not showing icons in the quickmenu

Looks like we're not handling the $(git-branch) icon correctly:

Issue 3: Not showing up in UX

We're currently missing the plumbing to show contributed tree view / pane items - so it's expected that it wouldn't show up in the UX yet. Related #1058

[iilonmasc]

I'm currently not able to reproduce this on current builds because the plugin got disabled/taken down (for now) from openvsx.

I'd mark this issue as "stale" or "waiting", if possible, until @alefragnani claims the plugin on openvsx and makes it available again.

[benwainwright]

@iilonmasc

Just downloaded the latest build from the website and installed this plugin via the sidebar. Can confirm pretty much exactly the same issues you describe. I really want this plugin, as it provides the workflow I originally proposed in https://github.com/onivim/oni2/issues/2823

cc. @bryphe