oni icon indicating copy to clipboard operation
oni copied to clipboard

Interactive tutorial broken in version 0.3.7 and 0.3.8

Open kifirkin opened this issue 6 years ago • 12 comments

Oni Version: 0.3.8 Neovim Version (Linux only): 0.3.1 Operating System: Ubuntu 18.04 x64

Issue: Interactive tutorial doesn't work. Unable to complete first task int first tutorial.

Expected behavior: Interactive tutorial inline window goes into insert mode and input text goes to that window

Actual behavior: When I press i key to switch into insert mode inside interactive tutorial inline window, whole Tutorial tab goes into insert mode and input text goes somewhere in background

Steps to reproduce: Open first task in first tutorial, press i. Whole tab goes into insert mode instead of inline window

kifirkin avatar Dec 17 '18 10:12 kifirkin

Hello and welcome to the Oni repository! Thanks for opening your first issue here. To help us out, please make sure to include as much detail as possible - including screenshots and logs, if possible.

oni-bot[bot] avatar Dec 17 '18 10:12 oni-bot[bot]

Version 0.3.9 has the same issue. seems like inline windows cant get focus

kifirkin avatar Dec 18 '18 07:12 kifirkin

I've found place where this bug was introduced https://github.com/onivim/oni/commit/e612eb860224d9f36528501cfd7c3a221e635305#r31743213

UPD: seems that is not true.

Inline editor didn't get focus. But I can't find why :sob:

kifirkin avatar Dec 20 '18 10:12 kifirkin

I seem to be experiencing this same issue with the mac version. v0.3.9

gtlaserbeast avatar Dec 21 '18 18:12 gtlaserbeast

Same here on Kubuntu 18.10 : v 0.3.9

Funeoz avatar Dec 23 '18 15:12 Funeoz

I've tried to debug this thing a little bit: So I set autoFocus = true here https://github.com/onivim/oni/blob/c7b11e462cc97f56fce313106570e5bb1e02eee5/browser/src/Services/Learning/Tutorial/TutorialBufferLayer.tsx#L126 , but it seems that it helps once, if I open another tutorial, inline editor looses focus again.

Also after completing tutorial there are two problems:

  1. Keystroke counter doesn't work
  2. Completion layer doesn't handle input keys, so I can't restart with space or continue with enter key

kifirkin avatar Dec 24 '18 09:12 kifirkin

I am experiencing this same problem in 0.3.9 for macos. It is a shame because I would love to complete all the tutorials

danielo515 avatar Feb 24 '19 08:02 danielo515

Having this issue on Windows. Oni 0.3.9 / NeoVim 0.3.1

yzlnew avatar Mar 06 '19 06:03 yzlnew

I'm experiencing this issue on 0.3.9 with neovim 0.3.4

frontendwizard avatar Mar 19 '19 19:03 frontendwizard

Same :(

goriunov avatar Mar 22 '19 05:03 goriunov

Same issue on Oni 0.3.9 and Neovim 0.3.4

slipsnip avatar Apr 23 '19 03:04 slipsnip

same pleas fix this soon neovim 0.4.3-1 oni 0.3.9-2

BigC4 avatar Dec 26 '19 00:12 BigC4