ElasticsearchDSL icon indicating copy to clipboard operation
ElasticsearchDSL copied to clipboard

Published 20 hours ago • verified publisher icon ongr-io

Search::setSource() now has a wrong phpdoc for the $source argument

Open pmishev opened this issue 6 years ago • 0 comments

For some reason, you've changed the correct @param array|bool|string $source to be @param bool $source in setSource() and now I'm getting warnings in PhpStorm when I pass an array to it.

https://github.com/ongr-io/ElasticsearchDSL/commit/48df0dcceb3e910617a348e8f70f0b7c7eaa7523#diff-e2ebe118f1e8dc3ba0a0e79a061a15ffL535

pmishev avatar Mar 22 '18 12:03 pmishev