flow icon indicating copy to clipboard operation
flow copied to clipboard

[REST] API client is sending in the block ids in the incorrect format

Open vishalchangrani opened this issue 3 years ago • 1 comments

Instructions

The Swagger Generated Go Client is sending the block ids in an incorrect format. It does a fmt.Sprintf("%v", id) for the id slice which causes the ids to be written out as [id1 id2 id3] etc. given how %v works for []string.

Current format

/v1/blocks/[id1 id1 id3...]

Correct format:

/v1/blocks/id1,id2,id3...

Problem

<what is the problem you've encountered?>

Steps to Reproduce

<share any logs/screenshots or steps to replicate>

Acceptance Criteria

Context

<what are you currently working on that this is blocking?>

vishalchangrani avatar Nov 19 '21 23:11 vishalchangrani

@vishalchangrani is that true for the JS generated client as well? I think we should focus on JS client and anyway we should support correct formatted IDs and then also add this parser exception, not just support the wrong one: https://github.com/onflow/flow-go/blob/rest_api_feature_branch/engine/access/rest/converter.go#L46 So IMHO we need to add support for the correct format and then special case handling of this format.

devbugging avatar Nov 24 '21 11:11 devbugging