flow icon indicating copy to clipboard operation
flow copied to clipboard

Domain tags

Open devbugging opened this issue 4 years ago • 5 comments

The docs don't include domain tags anywhere, especially the page: Documentation page: https://docs.onflow.org/concepts/accounts-and-keys/ should probably be updated to include them. It would be nice for domain tags to be explained separately and also how the payload is composed with them.

devbugging avatar Sep 07 '21 16:09 devbugging

what're domain tags?

mwufi avatar Nov 02 '21 18:11 mwufi

Domain tags is data that gets prefixed to the payload used for signing in order to prevent some malicious behaviour like giving a user to sign some data that is actually a transaction.

devbugging avatar Nov 03 '21 09:11 devbugging

To Kerry: Tarak has most context on this. Would recommend book a interview session with him to collect more details so that we can explain this in the Flow doc site

kerrywei avatar Dec 13 '21 18:12 kerrywei

As an example see: https://github.com/onflow/fcl-js/blob/master/packages/sdk/src/encode/encode.js#L15

justinbarry avatar Feb 08 '22 17:02 justinbarry

related issue: https://github.com/onflow/flow/issues/27

alxflw avatar Jun 21 '22 15:06 alxflw