flow-playground
flow-playground copied to clipboard
Update flow-js-testing handlebars templates to @[email protected]
Closes: #276
Description
For contributor use:
- [x] Targeted PR against correct branch (see CONTRIBUTING.md)
- [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [x] Code follows the standards mentioned here.
- [x] Updated relevant documentation
- [x] Re-reviewed
Files changed
in the Github PR explorer - [x] Added appropriate labels
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
flow-playground | ✅ Ready (Inspect) | Visit Preview | Sep 9, 2022 at 11:49PM (UTC) |
@alse @MrDSGC please take a look into this one if it's still relevant
@jribbink I'm seeing this error when exporting a project. It's not happening on the staging branch. src/templates/js/scriptUnitTest.hbs:20
Uncaught (in promise) SyntaxError: Unexpected token, expected "," (20:11) (at parser-babel.js?6103:1:1)
18 | code,
19 |
> 20 | });
| ^
21 | )
22 |
23 | // Add your expectations here
at t (parser-babel.js?6103:1:1)
at Object.eval [as parse] (parser-babel.js?6103:1:1)
at Object.parse (standalone.js?325b:15:1)
at ts (standalone.js?325b:15:1)
at us (standalone.js?325b:15:1)
at eval (standalone.js?325b:55:1)
at Object.format (standalone.js?325b:55:1)
at prettify (generator.ts?e988:18:1)
at generateScriptUnitTest (generator.ts?e988:251:1)
at eval (generator.ts?e988:288:1)
```
@jribbink I'm seeing this error when exporting a project. It's not happening on the staging branch. src/templates/js/scriptUnitTest.hbs:20
Uncaught (in promise) SyntaxError: Unexpected token, expected "," (20:11) (at parser-babel.js?6103:1:1) 18 | code, 19 | > 20 | }); | ^ 21 | ) 22 | 23 | // Add your expectations here at t (parser-babel.js?6103:1:1) at Object.eval [as parse] (parser-babel.js?6103:1:1) at Object.parse (standalone.js?325b:15:1) at ts (standalone.js?325b:15:1) at us (standalone.js?325b:15:1) at eval (standalone.js?325b:55:1) at Object.format (standalone.js?325b:55:1) at prettify (generator.ts?e988:18:1) at generateScriptUnitTest (generator.ts?e988:251:1) at eval (generator.ts?e988:288:1) ```
Apologies, that should be fixed now.
Thanks @jribbink , that fixed it. I followed the readme instructions to run the generated tests and I'm 6 were failing. Are they passing for you?
"execution error code 1006: [Error Code: 1006] invalid proposal key: public key 0 on account [...] does not have a valid signature: [Error Code: 1009] invalid envelope key: public key 0 on account [...] does not have a valid signature: signature is not valid"
flow cli version v0.39.3
closing, will need to reevaluate after polish sprint and mvp testing