flow-go icon indicating copy to clipboard operation
flow-go copied to clipboard
verified publisher icon onflow

[Malleability Immutable] Add ExecutionResult validation to UnsignedExecutionReceipt constructor

Open UlyanaAndrukhiv opened this issue 6 months ago • 0 comments

Context

Currentrly, the NewUnsignedExecutionReceipt constructor will still not validate the embedded ExecutionResult field because there is no constructor available for it yet. PR #7525 introduces the NewExecutionResult constructor, which will provide proper validation for the ExecutionResult type. Once that PR is merged, we should update NewUnsignedExecutionReceipt to call NewExecutionResult with the untrusted data, and return an error if the validation fails. A TODO comment is already present in the code to mark this spot.

Checklist

  • [ ] Uncomment and integrate the validation once PR #7525 is merged
  • [ ] Add corresponding unit test case and godoc to ensure invalid ExecutionResult values are rejected.

UlyanaAndrukhiv avatar Jun 24 '25 12:06 UlyanaAndrukhiv

build is failing the file quest-objectives.component.scss can be removed the interfaces can be moved in a separate file

Helias avatar Jun 25 '25 13:06 Helias

@Helias can you take over this PR? this just gives the base work and the idea

FrancescoBorzi avatar Jun 29 '25 09:06 FrancescoBorzi