flow-go icon indicating copy to clipboard operation
flow-go copied to clipboard

[EVM] Event addresses hex-encoded

Open devbugging opened this issue 9 months ago • 1 comments

Closes: #5911

Change address value in the EVM events CadenceOwnedAccountCreated FLOWTokensDeposited FLOWTokensWithdrawn to contain hex-encoded address as string instead of byte array, this makes it more useful for developers.

devbugging avatar May 16 '24 11:05 devbugging

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 55.81%. Comparing base (4f85bc2) to head (5837ad1).

Files Patch % Lines
fvm/evm/types/address.go 0.00% 7 Missing :warning:
utils/unittest/execution_state.go 0.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5933      +/-   ##
==========================================
+ Coverage   55.61%   55.81%   +0.19%     
==========================================
  Files        1128     1101      -27     
  Lines       88951    85969    -2982     
==========================================
- Hits        49470    47980    -1490     
+ Misses      34776    33382    -1394     
+ Partials     4705     4607      -98     
Flag Coverage Δ
unittests 55.81% <0.00%> (+0.19%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 16 '24 16:05 codecov-commenter