flow-go
flow-go copied to clipboard
[EVM] Using hex-encoded address as event values
EVM events CadenceOwnedAccountCreated
FLOWTokensDeposited
FLOWTokensWithdrawn
contain the EVM address as byte array, this is not great for human-readability and has been suggested we could change to hex-encoded addresses.
The original discussion: https://discord.com/channels/613813861610684416/1239301250630291517
@ramtinms @m-Peter Do you see any issues or reservations if we change this?
cc @bjartek @sisyphusSmiling @bluesign
I don't anticipate issues from my perspective. Human-readable events are definitely preferred, and the emitted string values can soon be deserialized into EVMAddress
objects with #5892. At this stage, are there any consumers that would be impacted by the event change - gateway, wallets, etc.?
Yeah, I like changing it to hex
Fine by me as well. This is already the case for the EVM.TransactionExecuted
event:
access(all)
event TransactionExecuted(
...
// if transaction was a deployment contains a newly deployed contract address
contractAddress: String,
...
)