[FVM] Refactoring TransactionProcedure trace span creation

[Tonix517]

• Adding IsSampled() to TransactionProcedure. Taking the message from computer.go to TransactionProcedure to make code slightly easier to read.
• Isolating boilerplace code for creating tracer span for TransactionProcedure into a function.

Test

• [X] all fvm UT

[github-actions[bot]]

FVM Benchstat comparison

This branch with compared with the base branch onflow:master commit d6b6b69d301ae90bb36e060691b0046365dda068

The command (for i in {1..10}; do go test ./fvm ./engine/execution/computation --bench . --tags relic -shuffle=on --benchmem --run ^$; done) was used.

Collapsed results for better readability

	old.txt	new.txt
	time/op		delta
ComputeBlock/16/cols/128/txes-2	5.48s ± 0%	5.62s ± 0%	~	(p=1.000 n=1+1)
	us/tx		delta
ComputeBlock/16/cols/128/txes-2	2.67k ± 0%	2.74k ± 0%	~	(p=1.000 n=1+1)
	alloc/op		delta
ComputeBlock/16/cols/128/txes-2	1.28GB ± 0%	1.28GB ± 0%	~	(p=1.000 n=1+1)
	allocs/op		delta
ComputeBlock/16/cols/128/txes-2	19.9M ± 0%	19.9M ± 0%	~	(p=1.000 n=1+1)

[codecov-commenter]

Codecov Report

Merging #3395 (857ef86) into master (95ca605) will increase coverage by 0.00%. The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           master    #3395    +/-   ##
========================================
  Coverage   55.47%   55.47%            
========================================
  Files         752      752            
  Lines       68292    68496   +204     
========================================
+ Hits        37886    38000   +114     
- Misses      27334    27424    +90     
  Partials     3072     3072            

Flag	Coverage Δ
unittests	55.47% <0.00%> (+<0.01%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
fvm/transaction.go	87.93% <0.00%> (-3.15%)	:arrow_down:
fvm/transactionInvoker.go	56.52% <0.00%> (ø)
fvm/transactionSequenceNum.go	66.66% <0.00%> (ø)
fvm/transactionVerifier.go	77.90% <0.00%> (ø)
insecure/orchestrator/corrupted_connection.go	74.50% <0.00%> (-7.85%)	:arrow_down:
fvm/environment/unsafe_random_generator.go	69.44% <0.00%> (-7.48%)	:arrow_down:
network/p2p/dns/resolver.go	91.51% <0.00%> (-4.85%)	:arrow_down:
fvm/environment/uuids.go	65.51% <0.00%> (-3.24%)	:arrow_down:
consensus/hotstuff/eventloop/event_loop.go	73.46% <0.00%> (-1.37%)	:arrow_down:
engine/consensus/compliance/core.go	74.30% <0.00%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[Tonix517]

bors merge

[bors[bot]]

Build succeeded:

• Integration Tests (make -C integration access-tests)
• Integration Tests (make -C integration bft-tests)
• Integration Tests (make -C integration collection-tests)
• Integration Tests (make -C integration consensus-tests)
• Integration Tests (make -C integration epochs-tests)
• Integration Tests (make -C integration execution-tests)
• Integration Tests (make -C integration ghost-tests)
• Integration Tests (make -C integration mvp-tests)
• Integration Tests (make -C integration network-tests)
• Integration Tests (make -C integration verification-tests)
• Lint (./)
• Lint (./crypto/)
• Lint (./integration/)
• Unit Tests (access)
• Unit Tests (admin)
• Unit Tests (cmd)
• Unit Tests (consensus)
• Unit Tests (engine)
• Unit Tests (fvm)
• Unit Tests (ledger)
• Unit Tests (module)
• Unit Tests (network)
• Unit Tests (others)
• Unit Tests (utils)