flow-go icon indicating copy to clipboard operation
flow-go copied to clipboard

return TotalComputationUsed() as uint64

Open pattyshack opened this issue 2 years ago • 2 comments

pattyshack avatar Oct 14 '22 17:10 pattyshack

FVM Benchstat comparison

This branch with compared with the base branch onflow:master commit 2440283d103da982734080064a9f738adf5bec48

The command (for i in {1..10}; do go test ./fvm ./engine/execution/computation --bench . --tags relic -shuffle=on --benchmem --run ^$; done) was used.

Collapsed results for better readability

old.txtnew.txt
time/opdelta
ComputeBlock/16/cols/128/txes-25.41s ± 0%5.35s ± 0%~(p=1.000 n=1+1)
 
us/txdelta
ComputeBlock/16/cols/128/txes-22.64k ± 0%2.61k ± 0%~(p=1.000 n=1+1)
 
alloc/opdelta
ComputeBlock/16/cols/128/txes-21.27GB ± 0%1.28GB ± 0%~(p=1.000 n=1+1)
 
allocs/opdelta
ComputeBlock/16/cols/128/txes-219.9M ± 0%19.9M ± 0%~(p=1.000 n=1+1)
 

github-actions[bot] avatar Oct 14 '22 17:10 github-actions[bot]

Codecov Report

Merging #3394 (f1436ed) into master (95ca605) will increase coverage by 6.28%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3394      +/-   ##
==========================================
+ Coverage   55.47%   61.76%   +6.28%     
==========================================
  Files         752      102     -650     
  Lines       68292     9217   -59075     
==========================================
- Hits        37886     5693   -32193     
+ Misses      27334     2959   -24375     
+ Partials     3072      565    -2507     
Flag Coverage Δ
unittests 61.76% <ø> (+6.28%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
consensus/hotstuff/eventloop/event_loop.go 73.46% <0.00%> (-1.37%) :arrow_down:
fvm/environment/meter.go
fvm/meter/meter.go
fvm/state/state.go
fvm/state/transaction_state.go
fvm/transactionInvoker.go
storage/badger/blocks.go
engine/access/rest/util/converter.go
module/mempool/stdmap/chunk_data_packs.go
engine/consensus/matching/engine.go
... and 641 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Oct 14 '22 17:10 codecov-commenter

bors merge

pattyshack avatar Oct 19 '22 16:10 pattyshack

This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried.

bors[bot] avatar Oct 19 '22 17:10 bors[bot]

bors retry

pattyshack avatar Oct 19 '22 17:10 pattyshack