flow-go icon indicating copy to clipboard operation
flow-go copied to clipboard

[FVM] Log fees error

Open janezpodhostnik opened this issue 3 years ago • 1 comments

Just an additional error to log if fee deduction fails.

janezpodhostnik avatar Oct 14 '22 14:10 janezpodhostnik

FVM Benchstat comparison

This branch with compared with the base branch onflow:master commit 0f23f9626ed82b37cfa5f7fc78ad1518f870f162

The command (for i in {1..10}; do go test ./fvm ./engine/execution/computation --bench . --tags relic -shuffle=on --benchmem --run ^$; done) was used.

Collapsed results for better readability

old.txtnew.txt
time/opdelta
ComputeBlock/16/cols/128/txes-26.83s ± 0%6.69s ± 0%~(p=1.000 n=1+1)
 
us/txdelta
ComputeBlock/16/cols/128/txes-23.33k ± 0%3.27k ± 0%~(p=1.000 n=1+1)
 
alloc/opdelta
ComputeBlock/16/cols/128/txes-21.27GB ± 0%1.28GB ± 0%~(p=1.000 n=1+1)
 
allocs/opdelta
ComputeBlock/16/cols/128/txes-219.8M ± 0%19.8M ± 0%~(p=1.000 n=1+1)
 

github-actions[bot] avatar Oct 14 '22 15:10 github-actions[bot]

bors merge

janezpodhostnik avatar Oct 18 '22 13:10 janezpodhostnik