flow-go icon indicating copy to clipboard operation
flow-go copied to clipboard

[Routing Attacks] Push Access Nodes To Edge (#3379)

Open vishalchangrani opened this issue 2 years ago • 3 comments

  • refactors go libp2p core dependency

  • lint fix

  • lint fix

  • lint

  • re-generates mocks

  • implements subscription provider

  • exports allowed subscription method

  • fix

  • implements subscription validator

  • renames a file

  • refactors packaging

  • lint fix

  • updates subscription validator

  • implements score options

  • removes set pubsub sytem

  • adds enabling gossipsub peer scoring

  • Adds enabling peer scoring for gossipsub to the builder

  • wires up identity provider

  • adds subscription provider interface

  • generates p2p mock

  • adds fixtures

  • adds topic provider mock

  • refactors subscription provider with topic provider

  • adds subscription provider

  • repackages translator

  • refactors translator and connector

  • lint fix

  • fixes import cycle

  • lint fix

  • fixes compile errors

  • fixes compile errors

  • fixes compile issues

  • lint fix

  • moves dht to its own package

  • lint fix

  • fix lint

  • wip

  • wip

  • fixes cyclic dependency due to libp2p utils

  • fixes internal dependencies

  • fixes cyclic dependency

  • fixes build issues

  • fixes compile issues

  • fixes build tests

  • fixes access builder

  • fixes observer node

  • fixes compile issues

  • fixes compile issues

  • fixes complie issues

  • fixes import cycle

  • lint fix

  • fix imports

  • renames node package

  • renames implementation

  • package renaming

  • lint fix

  • lint fix

  • lint fix

  • lint fix

  • lint fix

  • lint fix

  • lint fix

  • lint fix

  • lint fix

  • lint fix

  • resolves merge conflicts

  • lint fix

  • fix lint

  • fixes peer id fixture

  • adds godoc

  • moves identity provider interface to module package

  • generates mocks for module

  • generates mocks for network package

  • adds test with no subscribed topic

  • adds test for unknown subscription

  • adds test contain and exclude

  • adds godoc

  • adds helper methods

  • adds subscription validator tests

  • adds filter

  • adds filter test

  • refactors tests with filter

  • refactors valid subscription

  • refactors filter to exclude

  • adds test for subscription to all topics

  • adds exclude pattern tests

  • adds test for subscription validator

  • fixes builder issue with pubsub factory

  • lays out structure of integration test

  • migrates fixture

  • updates test

  • exports and moves a fixture

  • adds mvp subscription validator test

  • refactors test helpers

  • adds enable gossip sub peer scoring to node fixture

  • refactors missing score options

  • wip

  • resolves deadlock in libp2p

  • refactors with atomic

  • adds documentation

  • adds godoc

  • adds utils for slices

  • fixes tests

  • reverts a change

  • changes a log level

  • refactors a few test helpers

  • flips log level

  • adds godoc

  • refactors a method

  • adds godoc

  • adds godoc

  • lint fix

  • lint fix

  • lint fix

  • fix timeout

  • lint fix

  • lint fix

  • lint fix

  • lint fix

  • lint fix

  • sort imports

  • adds peer scoring as a flag

  • lint fix

  • adds test for excluding all elements

  • are string slices equal handles multiset

  • implements sentinel error

  • extends sentinel errors

  • Update network/p2p/scoring/subscription_provider.go

Co-authored-by: Peter Argue [email protected]

  • adds comment for peer scoring

  • renames a function

  • adds a todo

  • removes maybe off the mocks

  • extends test comment

  • adds role check for access node

  • adds test

  • refactors subscription validation

  • adds util tests

  • adds injectable app specific score

  • adds malicious AN tests

  • implements a helper

  • refactors test malicious access node

  • renames a test

  • fixes build errors

  • fixes tests

  • cosmotic

  • remove unused test helpers

  • adds full gossipsub connectivity test

  • refactors tests

  • adds godoc

  • lint fix

  • consolidates test helpers into one

  • refactors log level

  • increases a test size

Co-authored-by: Peter Argue [email protected] Co-authored-by: Vishal [email protected]

vishalchangrani avatar Oct 14 '22 00:10 vishalchangrani

Codecov Report

Merging #3389 (0f23f96) into v0.28 (95612b3) will decrease coverage by 0.03%. The diff coverage is 71.42%.

@@            Coverage Diff             @@
##            v0.28    #3389      +/-   ##
==========================================
- Coverage   55.48%   55.45%   -0.04%     
==========================================
  Files         751      752       +1     
  Lines       68231    68282      +51     
==========================================
+ Hits        37860    37866       +6     
- Misses      27301    27341      +40     
- Partials     3070     3075       +5     
Flag Coverage Δ
unittests 55.45% <71.42%> (-0.04%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
network/p2p/scoring/score_option.go 80.53% <65.62%> (-19.47%) :arrow_down:
network/p2p/scoring/subscription_validator.go 100.00% <100.00%> (ø)
network/p2p/scoring/utils.go 100.00% <100.00%> (ø)
...sus/approvals/assignment_collector_statemachine.go 41.30% <0.00%> (-7.25%) :arrow_down:
network/p2p/dns/resolver.go 91.51% <0.00%> (-4.85%) :arrow_down:
...s/hotstuff/votecollector/staking_vote_processor.go 80.64% <0.00%> (-3.23%) :arrow_down:
network/p2p/connection/peerManager.go 87.83% <0.00%> (-2.71%) :arrow_down:
consensus/hotstuff/eventloop/event_loop.go 73.46% <0.00%> (-1.37%) :arrow_down:
admin/command_runner.go 82.12% <0.00%> (ø)
engine/consensus/compliance/core.go 74.30% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Oct 14 '22 00:10 codecov-commenter

bors merge

vishalchangrani avatar Oct 14 '22 00:10 vishalchangrani

:-1: Rejected by too few approved reviews

bors[bot] avatar Oct 14 '22 00:10 bors[bot]