Adding Event Index Sequence checking to UTs

[Tonix517]

Adding new checking in UT cases to make sure numbers in event index sequence are unique and increasing. As a follow-up to https://github.com/onflow/flow-go/pull/3371#pullrequestreview-1139592903

changes to FVM and execution computer UT are split into separate commits.

[github-actions[bot]]

FVM Benchstat comparison

This branch with compared with the base branch onflow:master commit bba471cbc2881de71b1a69668f562e63826a1140

The command (for i in {1..10}; do go test ./fvm ./engine/execution/computation --bench . --tags relic -shuffle=on --benchmem --run ^$; done) was used.

Collapsed results for better readability

	old.txt	new.txt
	time/op		delta
ComputeBlock/16/cols/128/txes-2	4.53s ± 0%	4.68s ± 0%	~	(p=1.000 n=1+1)
	us/tx		delta
ComputeBlock/16/cols/128/txes-2	2.21k ± 0%	2.28k ± 0%	~	(p=1.000 n=1+1)
	alloc/op		delta
ComputeBlock/16/cols/128/txes-2	1.27GB ± 0%	1.29GB ± 0%	~	(p=1.000 n=1+1)
	allocs/op		delta
ComputeBlock/16/cols/128/txes-2	19.9M ± 0%	19.9M ± 0%	~	(p=1.000 n=1+1)

[codecov-commenter]

Codecov Report

Merging #3386 (d2b46d5) into master (ed91c80) will decrease coverage by 6.81%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3386      +/-   ##
==========================================
- Coverage   55.45%   48.64%   -6.82%     
==========================================
  Files         746      163     -583     
  Lines       67984    14297   -53687     
==========================================
- Hits        37703     6955   -30748     
+ Misses      27222     6907   -20315     
+ Partials     3059      435    -2624     

Flag	Coverage Δ
unittests	48.64% <ø> (-6.82%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
fvm/transactionInvoker.go	56.52% <0.00%> (-4.23%)	:arrow_down:
...s/hotstuff/votecollector/staking_vote_processor.go	83.87% <0.00%> (-3.23%)	:arrow_down:
consensus/hotstuff/eventloop/event_loop.go	73.46% <0.00%> (-1.37%)	:arrow_down:
fvm/environment/env.go	100.00% <0.00%> (ø)
admin/commands/storage/helper.go	78.00% <0.00%> (ø)
storage/badger/headers.go
network/channels/channel.go
ledger/complete/ledger.go
cmd/verification_builder.go
storage/badger/seals.go
... and 586 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[Tonix517]

bors merge

[Tonix517]

will merge it first and treat https://github.com/onflow/flow-go/issues/3393 as a separate fix in future PR

[bors[bot]]

Build succeeded:

• Integration Tests (make -C integration access-tests)
• Integration Tests (make -C integration bft-tests)
• Integration Tests (make -C integration collection-tests)
• Integration Tests (make -C integration consensus-tests)
• Integration Tests (make -C integration epochs-tests)
• Integration Tests (make -C integration execution-tests)
• Integration Tests (make -C integration ghost-tests)
• Integration Tests (make -C integration mvp-tests)
• Integration Tests (make -C integration network-tests)
• Integration Tests (make -C integration verification-tests)
• Lint (./)
• Lint (./crypto/)
• Lint (./integration/)
• Unit Tests (access)
• Unit Tests (admin)
• Unit Tests (cmd)
• Unit Tests (consensus)
• Unit Tests (engine)
• Unit Tests (fvm)
• Unit Tests (ledger)
• Unit Tests (module)
• Unit Tests (network)
• Unit Tests (others)
• Unit Tests (utils)