flow-go icon indicating copy to clipboard operation
flow-go copied to clipboard

Front-Load HotStuff Verification Pt. 2: Remove `MarkValid` API

Open jordanschalm opened this issue 2 years ago • 0 comments

This PR removes the MarkValid and ValidDescendants API methods:

  • In https://github.com/onflow/flow-go/pull/3294, we move HotStuff validation before compliance checks and persistence - this means that all stored blocks have passed both HotStuff and compliance validation
  • Therefore, there is no need for an additional validity flag - all blocks are valid by virtue of being persisted

⚠️ Depends on https://github.com/onflow/flow-go/pull/3294

jordanschalm avatar Sep 29 '22 14:09 jordanschalm