flow-go
flow-go copied to clipboard
onflow
Alter chainIDs to comply with the CAIP-2 standard
Problem
WalletConnect expects network IDs to be in a certain standardized format. I am hoping this PR will spark off a conversation on the downstream effects of this change.
See: https://github.com/ChainAgnostic/CAIPs/blob/master/CAIPs/caip-2.md
Codecov Report
Merging #3262 (9f766db) into master (6ce6e97) will decrease coverage by
2.60%. The diff coverage isn/a.
@@ Coverage Diff @@
## master #3262 +/- ##
==========================================
- Coverage 53.81% 51.20% -2.61%
==========================================
Files 741 501 -240
Lines 68515 42265 -26250
==========================================
- Hits 36868 21640 -15228
+ Misses 28605 18934 -9671
+ Partials 3042 1691 -1351
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 51.20% <ø> (-2.61%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| model/flow/chain.go | 57.42% <ø> (ø) |
|
| network/p2p/dns/resolver.go | 91.51% <0.00%> (-4.85%) |
:arrow_down: |
| cmd/scaffold.go | 17.30% <0.00%> (ø) |
|
| cmd/node_builder.go | 97.72% <0.00%> (ø) |
|
| cmd/execution_builder.go | 0.00% <0.00%> (ø) |
|
| network/test/testUtil.go | 94.83% <0.00%> (ø) |
|
| ...onsensus/approvals/caching_assignment_collector.go | ||
| ...ne/verification/assigner/blockconsumer/consumer.go | ||
| ledger/complete/wal/checksum.go | ||
| engine/access/rpc/backend/retry.go | ||
| ... and 264 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Also see
- ChainAgnostic Improvement Proposals CAIPs
- chain-naming-standard
- CAIP-2 CAIP-2 defines a way to identify a blockchain (e.g. Ethereum Mainnet, Görli, Bitcoin, Cosmos Hub) in a human-readable, developer-friendly and transaction-friendly way.
- chains-must-be-caip-2-compliant
—- CAIP-10 Extension specifies chain-agnostic account identifiers
- session-namespaces-addresses-must-be-caip-10-compliant
- https://github.com/ChainAgnostic/CAIPs/pull/10
- https://twitter.com/pedrouid/status/1369021474112147456
Is there any network (chain) using this standard? Or we will be the first ?
This seems WalletConnect standard tbh.
no movement here for a while, so going to assume there is no longer interest, feel free to re-open if there is renewed interest.
