[Draft] Execution Data State Sync Audit - Comments & Suggestions

[jordanschalm]

[codecov-commenter]

Codecov Report

Merging #3226 (95985c7) into master (fc4eda0) will decrease coverage by 7.27%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3226      +/-   ##
==========================================
- Coverage   53.93%   46.66%   -7.28%     
==========================================
  Files         742      182     -560     
  Lines       68375    19375   -49000     
==========================================
- Hits        36879     9041   -27838     
+ Misses      28445     9510   -18935     
+ Partials     3051      824    -2227     

Flag	Coverage Δ
unittests	46.66% <ø> (-7.28%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
fvm/handler/contract.go	66.18% <0.00%> (-6.50%)	:arrow_down:
fvm/environment/system_contracts.go	25.86% <0.00%> (-6.32%)	:arrow_down:
fvm/fvm.go	76.54% <0.00%> (-1.59%)	:arrow_down:
fvm/env.go	86.44% <0.00%> (-1.39%)	:arrow_down:
fvm/errors/errors.go	42.42% <0.00%> (-1.33%)	:arrow_down:
fvm/transactionInvoker.go	69.00% <0.00%> (-0.89%)	:arrow_down:
fvm/handler/accountKey.go	20.42% <0.00%> (-0.70%)	:arrow_down:
fvm/environment/account_creator.go	22.50% <0.00%> (-0.58%)	:arrow_down:
cmd/scaffold.go	17.30% <0.00%> (-0.04%)	:arrow_down:
fvm/bootstrap.go	86.26% <0.00%> (-0.03%)	:arrow_down:
... and 580 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[github-actions[bot]]

FVM Benchstat comparison

This branch with compared with the base branch onflow:master commit c58f31fe2d330b91c1008d7bdede151a3596374d

The command (for i in {1..10}; do go test ./fvm ./engine/execution/computation --bench . --tags relic -shuffle=on --benchmem --run ^$; done) was used.

Collapsed results for better readability

	old.txt	new.txt
	time/op		delta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeNFTBatchTransfer-2	113ms ± 4%	112ms ± 2%	~	(p=0.436 n=10+10)
RuntimeTransaction/reference_tx-2	28.4ms ±14%	27.0ms ± 6%	~	(p=0.079 n=10+9)
RuntimeTransaction/convert_int_to_string-2	30.0ms ± 9%	29.1ms ± 6%	~	(p=0.211 n=10+9)
RuntimeTransaction/get_signer_address-2	30.3ms ±10%	29.4ms ±16%	~	(p=0.165 n=10+10)
RuntimeTransaction/get_public_account-2	31.8ms ± 7%	31.6ms ± 7%	~	(p=0.780 n=10+9)
RuntimeTransaction/get_account_and_get_balance-2	316ms ±10%	309ms ± 2%	~	(p=0.182 n=9+10)
RuntimeTransaction/get_account_and_get_storage_used-2	34.1ms ± 4%	33.5ms ± 5%	~	(p=0.211 n=9+10)
RuntimeTransaction/get_account_and_get_storage_capacity-2	260ms ± 9%	254ms ± 1%	~	(p=0.094 n=9+9)
RuntimeTransaction/get_signer_vault-2	36.9ms ± 5%	36.1ms ± 9%	~	(p=0.247 n=10+10)
RuntimeTransaction/transfer_tokens-2	213ms ± 2%	211ms ± 3%	~	(p=0.353 n=10+10)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	36.2ms ± 7%	36.3ms ±10%	~	(p=0.971 n=10+10)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	79.0ms ± 3%	78.1ms ± 4%	~	(p=0.315 n=10+9)
RuntimeTransaction/create_new_account-2	850ms ± 2%	843ms ± 4%	~	(p=0.218 n=10+10)
RuntimeTransaction/call_empty_contract_function-2	31.8ms ± 7%	31.4ms ± 7%	~	(p=0.481 n=10+10)
RuntimeTransaction/emit_event-2	46.8ms ± 7%	45.9ms ± 8%	~	(p=0.393 n=10+10)
RuntimeTransaction/copy_array_from_storage-2	139ms ± 6%	137ms ± 4%	~	(p=0.315 n=10+10)
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-2	4.83s ± 3%	4.85s ± 3%	~	(p=0.481 n=10+10)
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/get_account_and_get_available_balance-2	290ms ± 3%	286ms ± 2%	−1.31%	(p=0.035 n=10+10)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	32.2ms ± 2%	31.5ms ± 3%	−2.27%	(p=0.004 n=9+8)
RuntimeTransaction/borrow_array_from_storage-2	133ms ± 3%	129ms ± 4%	−2.59%	(p=0.015 n=10+10)
RuntimeTransaction/get_signer_receiver-2	47.3ms ± 4%	45.9ms ± 5%	−2.96%	(p=0.022 n=9+10)
	alloc/op		delta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeNFTBatchTransfer-2	57.8MB ± 5%	58.1MB ± 3%	~	(p=0.631 n=10+10)
RuntimeTransaction/convert_int_to_string-2	37.2MB ± 9%	37.5MB ± 6%	~	(p=0.853 n=10+10)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	38.4MB ± 3%	38.0MB ± 9%	~	(p=0.762 n=8+10)
RuntimeTransaction/get_signer_address-2	38.4MB ± 5%	37.3MB ± 9%	~	(p=0.143 n=10+10)
RuntimeTransaction/get_public_account-2	38.2MB ± 6%	38.3MB ± 3%	~	(p=0.905 n=10+9)
RuntimeTransaction/get_account_and_get_balance-2	142MB ± 2%	141MB ± 0%	~	(p=0.161 n=10+7)
RuntimeTransaction/get_account_and_get_available_balance-2	123MB ± 3%	124MB ± 2%	~	(p=0.315 n=10+10)
RuntimeTransaction/get_account_and_get_storage_used-2	38.0MB ± 5%	38.1MB ± 4%	~	(p=0.796 n=10+10)
RuntimeTransaction/get_account_and_get_storage_capacity-2	118MB ± 4%	116MB ± 4%	~	(p=0.247 n=10+10)
RuntimeTransaction/get_signer_vault-2	39.0MB ± 8%	38.7MB ± 7%	~	(p=0.796 n=10+10)
RuntimeTransaction/get_signer_receiver-2	41.9MB ± 7%	41.5MB ± 6%	~	(p=0.481 n=10+10)
RuntimeTransaction/transfer_tokens-2	89.9MB ± 4%	90.1MB ± 4%	~	(p=0.971 n=10+10)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	38.1MB ± 6%	38.6MB ± 6%	~	(p=0.529 n=10+10)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	58.1MB ± 6%	58.3MB ± 2%	~	(p=0.684 n=10+10)
RuntimeTransaction/create_new_account-2	210MB ± 2%	209MB ± 0%	~	(p=1.000 n=10+8)
RuntimeTransaction/call_empty_contract_function-2	38.1MB ± 6%	38.1MB ± 7%	~	(p=1.000 n=10+10)
RuntimeTransaction/emit_event-2	43.2MB ± 6%	42.4MB ± 5%	~	(p=0.436 n=10+10)
RuntimeTransaction/borrow_array_from_storage-2	69.3MB ± 6%	68.5MB ± 6%	~	(p=0.684 n=10+10)
RuntimeTransaction/copy_array_from_storage-2	83.5MB ± 4%	84.3MB ± 2%	~	(p=0.529 n=10+10)
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-2	1.32GB ± 1%	1.32GB ± 0%	~	(p=0.079 n=10+9)
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/reference_tx-2	37.8MB ± 5%	36.5MB ± 6%	−3.54%	(p=0.031 n=9+9)
	allocs/op		delta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeNFTBatchTransfer-2	304k ± 0%	304k ± 0%	~	(p=0.255 n=10+10)
RuntimeTransaction/get_account_and_get_available_balance-2	1.58M ± 0%	1.58M ± 0%	~	(p=0.218 n=10+10)
RuntimeTransaction/get_account_and_get_storage_capacity-2	1.42M ± 0%	1.42M ± 0%	~	(p=0.078 n=10+10)
RuntimeTransaction/create_new_account-2	2.80M ± 0%	2.80M ± 0%	~	(p=0.190 n=10+10)
RuntimeTransaction/copy_array_from_storage-2	335k ± 0%	335k ± 0%	~	(p=0.280 n=10+10)
RuntimeTransaction/get_account_and_get_balance-2	1.71M ± 0%	1.71M ± 0%	−0.00%	(p=0.042 n=9+9)
RuntimeTransaction/transfer_tokens-2	971k ± 0%	971k ± 0%	−0.01%	(p=0.022 n=10+10)
RuntimeTransaction/borrow_array_from_storage-2	379k ± 0%	379k ± 0%	−0.02%	(p=0.000 n=10+10)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	242k ± 0%	242k ± 0%	−0.02%	(p=0.000 n=7+10)
RuntimeTransaction/get_signer_receiver-2	222k ± 0%	222k ± 0%	−0.02%	(p=0.000 n=10+10)
RuntimeTransaction/get_account_and_get_storage_used-2	139k ± 0%	139k ± 0%	−0.03%	(p=0.000 n=9+9)
RuntimeTransaction/get_signer_vault-2	141k ± 0%	141k ± 0%	−0.03%	(p=0.000 n=10+7)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	140k ± 0%	140k ± 0%	−0.03%	(p=0.000 n=10+9)
RuntimeTransaction/emit_event-2	151k ± 0%	151k ± 0%	−0.03%	(p=0.000 n=10+10)
RuntimeTransaction/get_public_account-2	118k ± 0%	118k ± 0%	−0.03%	(p=0.000 n=10+9)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	118k ± 0%	118k ± 0%	−0.04%	(p=0.000 n=9+10)
RuntimeTransaction/call_empty_contract_function-2	106k ± 0%	106k ± 0%	−0.04%	(p=0.000 n=8+10)
RuntimeTransaction/convert_int_to_string-2	104k ± 0%	104k ± 0%	−0.04%	(p=0.000 n=10+10)
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-2	21.0M ± 0%	21.0M ± 0%	−0.05%	(p=0.000 n=10+10)
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/reference_tx-2	89.5k ± 0%	89.5k ± 0%	−0.05%	(p=0.000 n=10+10)
RuntimeTransaction/get_signer_address-2	94.7k ± 0%	94.7k ± 0%	−0.05%	(p=0.000 n=10+10)
	computation		delta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/reference_tx-2	202 ± 0%	202 ± 0%	~	(all equal)
RuntimeTransaction/convert_int_to_string-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	502 ± 0%	502 ± 0%	~	(all equal)
RuntimeTransaction/get_signer_address-2	302 ± 0%	302 ± 0%	~	(all equal)
RuntimeTransaction/get_public_account-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_balance-2	1.00k ± 0%	1.00k ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_available_balance-2	2.60k ± 0%	2.60k ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_storage_used-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_storage_capacity-2	1.30k ± 0%	1.30k ± 0%	~	(all equal)
RuntimeTransaction/get_signer_vault-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/get_signer_receiver-2	602 ± 0%	602 ± 0%	~	(all equal)
RuntimeTransaction/transfer_tokens-2	3.50k ± 0%	3.50k ± 0%	~	(all equal)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	602 ± 0%	602 ± 0%	~	(all equal)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	602 ± 0%	602 ± 0%	~	(all equal)
RuntimeTransaction/create_new_account-2	202 ± 0%	202 ± 0%	~	(all equal)
RuntimeTransaction/call_empty_contract_function-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/emit_event-2	602 ± 0%	602 ± 0%	~	(all equal)
RuntimeTransaction/borrow_array_from_storage-2	2.60k ± 0%	2.60k ± 0%	~	(all equal)
RuntimeTransaction/copy_array_from_storage-2	2.60k ± 0%	2.60k ± 0%	~	(all equal)
	interactions		delta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/reference_tx-2	44.4k ± 0%	44.4k ± 0%	~	(all equal)
RuntimeTransaction/convert_int_to_string-2	44.4k ± 0%	44.4k ± 0%	~	(all equal)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	44.4k ± 0%	44.4k ± 0%	~	(all equal)
RuntimeTransaction/get_signer_address-2	44.4k ± 0%	44.4k ± 0%	~	(all equal)
RuntimeTransaction/get_public_account-2	44.4k ± 0%	44.4k ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_balance-2	16.8M ± 0%	16.8M ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_available_balance-2	5.28M ± 0%	5.28M ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_storage_used-2	48.0k ± 0%	48.0k ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_storage_capacity-2	5.27M ± 0%	5.27M ± 0%	~	(all equal)
RuntimeTransaction/get_signer_vault-2	44.7k ± 0%	44.7k ± 0%	~	(all equal)
RuntimeTransaction/get_signer_receiver-2	45.0k ± 0%	45.0k ± 0%	~	(all equal)
RuntimeTransaction/transfer_tokens-2	45.8k ± 0%	45.8k ± 0%	~	(all equal)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	44.8k ± 0%	44.8k ± 0%	~	(all equal)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	49.7k ± 0%	49.7k ± 0%	~	(all equal)
RuntimeTransaction/create_new_account-2	8.53M ± 0%	8.53M ± 0%	~	(all equal)
RuntimeTransaction/call_empty_contract_function-2	44.6k ± 0%	44.6k ± 0%	~	(all equal)
RuntimeTransaction/emit_event-2	44.6k ± 0%	44.6k ± 0%	~	(all equal)
RuntimeTransaction/borrow_array_from_storage-2	49.8k ± 0%	49.8k ± 0%	~	(all equal)
RuntimeTransaction/copy_array_from_storage-2	49.8k ± 0%	49.8k ± 0%	~	(all equal)
	us/tx		delta
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-2	2.36k ± 3%	2.37k ± 3%	~	(p=0.528 n=10+10)