Bootstrap to single address

[janezpodhostnik]

This changes bootstrapping to bootstrap all core contracts to one address (the service account address)

The benefit is that all contracts are on one account which makes it easier for all transient chain users to manage stuff. Transient chains being: Benchnet, Emulator, (Playground), ...

the drawback is that the bootstrapped account structure is not the same as on mainnet or testnet or canary or Sandboxnet. But that was already the case for the epoch part of bootstrapping.

[github-actions[bot]]

FVM Benchstat comparison

This branch with compared with the base branch onflow:master commit cdf74677f2c02dd56ad967a3e00db580c72ce744

The command (for i in {1..10}; do go test ./fvm ./engine/execution/computation --bench . --tags relic -shuffle=on --benchmem --run ^$; done) was used.

Collapsed results for better readability

	old.txt	new.txt
	time/op		delta
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-2	4.69s ± 3%	4.50s ± 0%	~	(p=0.182 n=10+1)
	alloc/op		delta
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-2	1.32GB ± 1%	1.22GB ± 0%	~	(p=0.182 n=10+1)
	allocs/op		delta
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-2	21.0M ± 0%	18.5M ± 0%	~	(p=0.182 n=10+1)
	us/tx		delta
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-2	2.29k ± 3%	2.20k ± 0%	~	(p=0.182 n=10+1)

[codecov-commenter]

Codecov Report

Merging #3218 (ab29ab1) into master (cdf7467) will increase coverage by 0.01%. The diff coverage is 86.04%.

@@            Coverage Diff             @@
##           master    #3218      +/-   ##
==========================================
+ Coverage   53.82%   53.84%   +0.01%     
==========================================
  Files         741      741              
  Lines       68539    68543       +4     
==========================================
+ Hits        36890    36904      +14     
+ Misses      28605    28597       -8     
+ Partials     3044     3042       -2     

Flag	Coverage Δ
unittests	53.84% <86.04%> (+0.01%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cmd/bootstrap/cmd/partner_infos.go	6.25% <0.00%> (+0.09%)	:arrow_up:
cmd/execution_builder.go	0.00% <0.00%> (ø)
cmd/util/cmd/epochs/cmd/deploy.go	7.24% <0.00%> (+0.03%)	:arrow_up:
fvm/environment/system_contracts.go	25.86% <0.00%> (ø)
fvm/errors/codes.go	100.00% <ø> (ø)
utils/unittest/execution_state.go	58.33% <ø> (ø)
utils/unittest/fixtures.go	0.00% <0.00%> (ø)
engine/access/rpc/backend/backend_transactions.go	50.46% <50.00%> (+0.46%)	:arrow_up:
fvm/bootstrap.go	85.67% <91.93%> (-0.60%)	:arrow_down:
fvm/systemcontracts/system_contracts.go	94.16% <93.87%> (-1.44%)	:arrow_down:
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[janezpodhostnik]

bors try

[bors[bot]]

try

Merge conflict.

[Kay-Zee]

what's the status here @janezpodhostnik

[janezpodhostnik]

This is probably something we still want to do, but this PR is old, and its easier to just do it again.