Aug 23 '22 01:08 synzhu

Codecov Report

Merging #3064 (e2187d3) into master (d7ab76d) will increase coverage by 0.01%. The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master    #3064      +/-   ##
==========================================
+ Coverage   55.26%   55.27%   +0.01%     
==========================================
  Files         760      760              
  Lines       69716    69718       +2     
==========================================
+ Hits        38526    38536      +10     
+ Misses      28024    28017       -7     
+ Partials     3166     3165       -1

Flag	Coverage Δ
unittests	`55.27% <25.00%> (+0.01%)`	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
module/executiondatasync/tracker/storage.go	`58.60% <ø> (ø)`
module/executiondatasync/provider/provider.go	`66.87% <25.00%> (-1.51%)`	:arrow_down:
consensus/hotstuff/eventloop/event_loop.go	`73.46% <0.00%> (-1.37%)`	:arrow_down:
state/protocol/badger/state.go	`52.65% <0.00%> (-0.67%)`	:arrow_down:
engine/consensus/compliance/core.go	`74.60% <0.00%> (ø)`
state/protocol/badger/validity.go	`48.96% <0.00%> (+1.24%)`	:arrow_up:
...s/hotstuff/votecollector/staking_vote_processor.go	`87.09% <0.00%> (+3.22%)`	:arrow_up:
...sus/approvals/assignment_collector_statemachine.go	`48.55% <0.00%> (+7.24%)`	:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Aug 23 '22 01:08 codecov-commenter

@smnzhu can you add some context to the description on what this change is fixing?

Oct 12 '22 20:10 peterargue

bors merge

Oct 19 '22 21:10 synzhu

Build failed:

Unit Tests (module)

Oct 19 '22 21:10 bors[bot]

@smnzhu Looks like there are some legit unit test failures

Oct 21 '22 00:10 peterargue

FVM Benchstat comparison

This branch with compared with the base branch onflow:master commit 02e9bc3e83688c7c9697b33f52d70c57778855be

The command (for i in {1..7}; do go test ./fvm ./engine/execution/computation --bench . --tags relic -shuffle=on --benchmem --run ^$; done) was used.

Collapsed results for better readability

	old.txt	new.txt
	time/op		delta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeNFTBatchTransfer-2	116ms ± 3%	117ms ± 1%	~	(p=0.537 n=6+5)
RuntimeTransaction/reference_tx-2	31.6ms ±21%	31.5ms ±14%	~	(p=0.535 n=7+7)
RuntimeTransaction/convert_int_to_string-2	30.5ms ± 4%	30.5ms ± 3%	~	(p=0.628 n=6+7)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	32.1ms ± 2%	32.2ms ± 3%	~	(p=0.836 n=6+7)
RuntimeTransaction/get_signer_address-2	30.1ms ± 2%	29.9ms ± 5%	~	(p=0.937 n=6+6)
RuntimeTransaction/get_public_account-2	32.1ms ± 5%	33.3ms ±10%	~	(p=0.165 n=7+7)
RuntimeTransaction/get_account_and_get_balance-2	260ms ± 2%	261ms ± 3%	~	(p=0.805 n=7+7)
RuntimeTransaction/get_account_and_get_available_balance-2	238ms ± 1%	238ms ± 2%	~	(p=0.902 n=7+7)
RuntimeTransaction/get_account_and_get_storage_used-2	34.6ms ± 3%	34.0ms ± 4%	~	(p=0.383 n=7+7)
RuntimeTransaction/get_account_and_get_storage_capacity-2	214ms ± 3%	215ms ± 2%	~	(p=0.902 n=7+7)
RuntimeTransaction/get_signer_vault-2	36.5ms ± 3%	36.2ms ± 2%	~	(p=0.445 n=7+6)
RuntimeTransaction/get_signer_receiver-2	46.8ms ± 3%	47.1ms ± 4%	~	(p=0.805 n=7+7)
RuntimeTransaction/transfer_tokens-2	190ms ± 2%	190ms ± 2%	~	(p=0.902 n=7+7)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	35.7ms ± 4%	35.0ms ± 0%	~	(p=0.106 n=7+5)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	76.9ms ± 6%	78.1ms ± 3%	~	(p=0.318 n=7+7)
RuntimeTransaction/create_new_account-2	802ms ± 1%	803ms ± 1%	~	(p=0.620 n=7+7)
RuntimeTransaction/call_empty_contract_function-2	31.9ms ± 4%	32.1ms ± 3%	~	(p=0.535 n=7+7)
RuntimeTransaction/emit_event-2	46.1ms ± 3%	45.8ms ± 6%	~	(p=0.805 n=7+7)
RuntimeTransaction/borrow_array_from_storage-2	127ms ± 2%	126ms ± 2%	~	(p=0.259 n=7+7)
RuntimeTransaction/copy_array_from_storage-2	126ms ± 2%	128ms ± 1%	~	(p=0.097 n=7+7)
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-2	4.31s ± 1%	4.30s ± 1%	~	(p=0.295 n=7+6)

	alloc/op		delta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/get_account_and_get_balance-2	119MB ± 2%	122MB ± 0%	+1.76%	(p=0.018 n=7+5)
RuntimeTransaction/get_signer_address-2	35.0MB ± 2%	35.4MB ± 1%	+1.33%	(p=0.035 n=7+6)
RuntimeNFTBatchTransfer-2	54.9MB ± 3%	54.5MB ± 3%	~	(p=0.295 n=6+7)
RuntimeTransaction/reference_tx-2	35.4MB ± 4%	35.2MB ± 3%	~	(p=0.805 n=7+7)
RuntimeTransaction/convert_int_to_string-2	34.5MB ± 2%	34.8MB ± 2%	~	(p=0.209 n=7+7)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	35.7MB ± 5%	35.3MB ± 3%	~	(p=0.259 n=7+7)
RuntimeTransaction/get_public_account-2	35.9MB ± 2%	36.4MB ± 3%	~	(p=0.209 n=7+7)
RuntimeTransaction/get_account_and_get_available_balance-2	106MB ± 2%	107MB ± 3%	~	(p=0.097 n=7+7)
RuntimeTransaction/get_account_and_get_storage_used-2	36.8MB ± 2%	36.4MB ± 4%	~	(p=0.383 n=7+7)
RuntimeTransaction/get_account_and_get_storage_capacity-2	102MB ± 5%	102MB ± 4%	~	(p=0.710 n=7+7)
RuntimeTransaction/get_signer_vault-2	37.3MB ± 4%	37.0MB ± 2%	~	(p=0.318 n=7+7)
RuntimeTransaction/get_signer_receiver-2	40.9MB ± 4%	41.7MB ± 6%	~	(p=0.383 n=7+7)
RuntimeTransaction/transfer_tokens-2	83.9MB ± 3%	84.3MB ± 3%	~	(p=1.000 n=7+7)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	35.8MB ± 1%	35.9MB ± 1%	~	(p=0.710 n=7+7)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	52.5MB ± 5%	52.7MB ± 3%	~	(p=0.620 n=7+7)
RuntimeTransaction/create_new_account-2	184MB ± 3%	181MB ± 1%	~	(p=0.259 n=7+7)
RuntimeTransaction/call_empty_contract_function-2	35.6MB ± 2%	35.5MB ± 1%	~	(p=0.755 n=7+5)
RuntimeTransaction/emit_event-2	40.4MB ± 4%	40.4MB ± 3%	~	(p=0.805 n=7+7)
RuntimeTransaction/borrow_array_from_storage-2	70.1MB ± 2%	69.7MB ± 5%	~	(p=0.805 n=7+7)
RuntimeTransaction/copy_array_from_storage-2	81.2MB ± 1%	81.7MB ± 3%	~	(p=0.902 n=7+7)
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-2	1.21GB ± 2%	1.20GB ± 1%	~	(p=0.902 n=7+7)

	allocs/op		delta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/reference_tx-2	82.7k ± 0%	82.8k ± 0%	+0.18%	(p=0.001 n=7+7)
RuntimeTransaction/get_signer_address-2	86.9k ± 0%	87.0k ± 0%	+0.17%	(p=0.001 n=7+7)
RuntimeTransaction/convert_int_to_string-2	94.9k ± 0%	95.0k ± 0%	+0.16%	(p=0.001 n=7+7)
RuntimeTransaction/call_empty_contract_function-2	98.2k ± 0%	98.3k ± 0%	+0.15%	(p=0.001 n=7+7)
RuntimeTransaction/get_public_account-2	109k ± 0%	109k ± 0%	+0.14%	(p=0.001 n=7+7)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	106k ± 0%	106k ± 0%	+0.14%	(p=0.001 n=7+7)
RuntimeTransaction/get_account_and_get_storage_used-2	119k ± 0%	119k ± 0%	+0.13%	(p=0.001 n=7+6)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	122k ± 0%	122k ± 0%	+0.12%	(p=0.001 n=7+7)
RuntimeTransaction/get_signer_vault-2	123k ± 0%	123k ± 0%	+0.12%	(p=0.001 n=7+7)
RuntimeTransaction/emit_event-2	138k ± 0%	138k ± 0%	+0.11%	(p=0.001 n=7+7)
RuntimeTransaction/get_signer_receiver-2	198k ± 0%	198k ± 0%	+0.08%	(p=0.001 n=7+7)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	194k ± 0%	194k ± 0%	+0.08%	(p=0.001 n=7+7)
RuntimeTransaction/copy_array_from_storage-2	293k ± 0%	293k ± 0%	+0.05%	(p=0.001 n=7+7)
RuntimeTransaction/borrow_array_from_storage-2	336k ± 0%	336k ± 0%	+0.04%	(p=0.001 n=7+7)
RuntimeTransaction/get_account_and_get_available_balance-2	1.23M ± 0%	1.23M ± 0%	+0.01%	(p=0.001 n=7+7)
RuntimeTransaction/get_account_and_get_storage_capacity-2	1.11M ± 0%	1.11M ± 0%	+0.01%	(p=0.001 n=7+7)
RuntimeTransaction/get_account_and_get_balance-2	1.30M ± 0%	1.30M ± 0%	+0.01%	(p=0.001 n=7+6)
RuntimeTransaction/transfer_tokens-2	842k ± 0%	842k ± 0%	+0.01%	(p=0.001 n=7+6)
RuntimeNFTBatchTransfer-2	269k ± 0%	268k ± 1%	~	(p=0.094 n=6+7)
RuntimeTransaction/create_new_account-2	2.27M ± 0%	2.27M ± 0%	~	(p=0.165 n=7+7)
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-2	17.2M ± 0%	17.2M ± 0%	~	(p=0.128 n=7+7)

	computation		delta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/reference_tx-2	202 ± 0%	202 ± 0%	~	(all equal)
RuntimeTransaction/convert_int_to_string-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	502 ± 0%	502 ± 0%	~	(all equal)
RuntimeTransaction/get_signer_address-2	302 ± 0%	302 ± 0%	~	(all equal)
RuntimeTransaction/get_public_account-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_balance-2	1.00k ± 0%	1.00k ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_available_balance-2	3.10k ± 0%	3.10k ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_storage_used-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_storage_capacity-2	1.70k ± 0%	1.70k ± 0%	~	(all equal)
RuntimeTransaction/get_signer_vault-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/get_signer_receiver-2	602 ± 0%	602 ± 0%	~	(all equal)
RuntimeTransaction/transfer_tokens-2	3.50k ± 0%	3.50k ± 0%	~	(all equal)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	602 ± 0%	602 ± 0%	~	(all equal)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	602 ± 0%	602 ± 0%	~	(all equal)
RuntimeTransaction/create_new_account-2	202 ± 0%	202 ± 0%	~	(all equal)
RuntimeTransaction/call_empty_contract_function-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/emit_event-2	602 ± 0%	602 ± 0%	~	(all equal)
RuntimeTransaction/borrow_array_from_storage-2	2.60k ± 0%	2.60k ± 0%	~	(all equal)
RuntimeTransaction/copy_array_from_storage-2	2.60k ± 0%	2.60k ± 0%	~	(all equal)

	interactions		delta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/reference_tx-2	331k ± 0%	331k ± 0%	~	(all equal)
RuntimeTransaction/convert_int_to_string-2	331k ± 0%	331k ± 0%	~	(all equal)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	331k ± 0%	331k ± 0%	~	(all equal)
RuntimeTransaction/get_signer_address-2	331k ± 0%	331k ± 0%	~	(all equal)
RuntimeTransaction/get_public_account-2	331k ± 0%	331k ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_balance-2	24.3M ± 0%	24.3M ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_available_balance-2	5.64M ± 0%	5.64M ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_storage_used-2	331k ± 0%	331k ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_storage_capacity-2	5.64M ± 0%	5.64M ± 0%	~	(all equal)
RuntimeTransaction/get_signer_vault-2	331k ± 0%	331k ± 0%	~	(all equal)
RuntimeTransaction/get_signer_receiver-2	331k ± 0%	331k ± 0%	~	(all equal)
RuntimeTransaction/transfer_tokens-2	331k ± 0%	331k ± 0%	~	(all equal)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	331k ± 0%	331k ± 0%	~	(all equal)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	334k ± 0%	334k ± 0%	~	(all equal)
RuntimeTransaction/create_new_account-2	12.3M ± 0%	12.3M ± 0%	~	(all equal)
RuntimeTransaction/call_empty_contract_function-2	331k ± 0%	331k ± 0%	~	(all equal)
RuntimeTransaction/emit_event-2	331k ± 0%	331k ± 0%	~	(all equal)
RuntimeTransaction/borrow_array_from_storage-2	336k ± 0%	336k ± 0%	~	(all equal)
RuntimeTransaction/copy_array_from_storage-2	336k ± 0%	336k ± 0%	~	(all equal)

	us/tx		delta
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-2	2.11k ± 1%	2.10k ± 1%	~	(p=0.314 n=7+6)