flow-go icon indicating copy to clipboard operation
flow-go copied to clipboard

[BFT Testing] Corrupting ingress traffic (part-3, process ingress message)

Open gomisha opened this issue 3 years ago • 1 comments

  • added HandleEventToCorruptedNode() to AttackOrchestrator interface
  • added SendIngress() to AttackNetwork interface
  • updated implementation for HandleIncomeEvent() for IngressController to return bool depending on whether attacker is registered with the corrupted network
  • renamed WithAttacker() to Register() in AttackOrchestrator interface
  • updated dummy and Wintermute orchestrators to panic on ingress messages (needs implementation and testing that will be done in separate PR)
  • renamed attacknetwork package to orchestrator
  • renamed attacknetwork.AttackNetwork to orchestrator.OrchestratorNetwork which implements insecure.OrchestratorNetwork interface
  • changed all references to attack network / attackNetwork to orchestrator network / orchestratorNetwork

gomisha avatar Aug 05 '22 14:08 gomisha

Codecov Report

Merging #2936 (f0ad8fc) into master (5b5125d) will decrease coverage by 0.07%. The diff coverage is 48.14%.

@@            Coverage Diff             @@
##           master    #2936      +/-   ##
==========================================
- Coverage   54.50%   54.43%   -0.08%     
==========================================
  Files         722      722              
  Lines       66719    66821     +102     
==========================================
+ Hits        36366    36371       +5     
- Misses      27303    27399      +96     
- Partials     3050     3051       +1     
Flag Coverage Δ
unittests 54.43% <48.14%> (-0.08%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
insecure/corruptible/conduit.go 55.88% <ø> (ø)
insecure/corruptible/factory.go 87.03% <ø> (ø)
insecure/corruptible/message_processor.go 0.00% <0.00%> (ø)
insecure/orchestrator/corrupted_connection.go 74.50% <ø> (ø)
insecure/orchestrator/corrupted_connector.go 68.08% <ø> (ø)
insecure/corruptible/network.go 57.04% <34.40%> (-9.63%) :arrow_down:
insecure/orchestrator/network.go 54.66% <54.66%> (ø)
insecure/wintermute/attackOrchestrator.go 72.04% <58.82%> (-4.04%) :arrow_down:
insecure/integration/test/mock_orchestrator.go 71.42% <66.66%> (-28.58%) :arrow_down:
insecure/corruptible/network_test_helpers.go 97.53% <100.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Aug 15 '22 20:08 codecov-commenter

bors merge

gomisha avatar Aug 23 '22 16:08 gomisha

Canceled.

bors[bot] avatar Aug 23 '22 17:08 bors[bot]

bors merge

gomisha avatar Aug 23 '22 18:08 gomisha