(WIP) [EN Performance] Split Node into LeafNode and InterimNode

[fxamacker]

Changes

Split Node into LeafNode and InterimNode and remove unnecessary fields to reduce memory:

• 16 bytes for each leaf node
• 24 bytes for each interim node

Create Node interface with read-only functions for LeafNode and InterimNode.

Updates Epic #1744

Caveats

• 🚧 WIP - Looking into why benchnet test shows only 4.4GB savings (expected more).
• 🐢 Calling interface methods which cannot be inlined will have a performance cost.
• ⚠️ Need to decide if the memory savings doesn't outweigh the performance cost.

[codecov-commenter]

Codecov Report

Merging #2265 (7ed3b47) into master (ba1f157) will decrease coverage by 0.08%. The diff coverage is 48.72%.

@@            Coverage Diff             @@
##           master    #2265      +/-   ##
==========================================
- Coverage   57.47%   57.38%   -0.09%     
==========================================
  Files         645      651       +6     
  Lines       38428    39138     +710     
==========================================
+ Hits        22085    22458     +373     
- Misses      13530    13810     +280     
- Partials     2813     2870      +57     

Flag	Coverage Δ
unittests	57.38% <48.72%> (-0.09%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cmd/bootstrap/transit/cmd/version.go	14.28% <ø> (ø)
cmd/util/ledger/reporters/export_reporter.go	0.00% <0.00%> (ø)
engine/common/rpc/convert/convert.go	16.07% <0.00%> (+2.13%)	:arrow_up:
engine/execution/state/state.go	22.12% <0.00%> (-0.53%)	:arrow_down:
storage/badger/commits.go	90.00% <0.00%> (-3.11%)	:arrow_down:
storage/badger/events.go	53.24% <0.00%> (-1.42%)	:arrow_down:
storage/badger/headers.go	44.33% <0.00%> (-9.07%)	:arrow_down:
storage/badger/my_receipts.go	58.73% <0.00%> (-0.95%)	:arrow_down:
storage/badger/operation/chunkDataPacks.go	75.00% <0.00%> (ø)
storage/badger/operation/commits.go	50.00% <0.00%> (-16.67%)	:arrow_down:
... and 42 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b341963...7ed3b47. Read the comment docs.

[Kay-Zee]

@fxamacker @ramtinms @m4ksio What's the status on this issue? Getting quite stale.

[fxamacker]

@Kay-Zee This was paused because it sacrifices EN performance to gain memory (for both reads and updates). In August Spork, checkpoint v5 memory reductions (especially after PR 3050 got deployed to mainnet before October Spork) made it less important for EN to reduce memory by sacrificing performance.

I can close this for now and it can be reopened if needed.

Thoughts?

cc: @ramtinms

[fxamacker]

Confirmed with @ramtinms that this can be closed for now.