flow-go-sdk icon indicating copy to clipboard operation
flow-go-sdk copied to clipboard

Add unimplemented interface

Open peterargue opened this issue 11 months ago • 1 comments

Closes: #???

Description

Possible approach to reduce boilerplate for unimplemented methods


For contributor use:

  • [ ] Targeted PR against master branch
  • [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • [ ] Code follows the standards mentioned here.
  • [ ] Updated relevant documentation
  • [ ] Re-reviewed Files changed in the Github PR explorer
  • [ ] Added appropriate labels

peterargue avatar Mar 06 '25 15:03 peterargue

This feels a bit wrong. ( according to https://github.com/onflow/flow-go-sdk/tree/master/access )

Each implementation (currently grpc and http) include the following parts: Base Client is the client that implements the client interface exposing all generic functionality. Client is the network specific client that exposes any additional options possible by the specific API implementation. Handler takes care of actual network communication implementing the communication protocol.

Shouldn't all functions in generic ( I think this means common subset ) implemented as exposed as interface ?

PS: I think this is somehow issue with initial implementation not this PR

bluesign avatar Mar 10 '25 15:03 bluesign