flow-go-sdk icon indicating copy to clipboard operation
flow-go-sdk copied to clipboard

Remove contract hex encoding

Open nozim opened this issue 2 years ago • 10 comments

Closes: #467

Description


For contributor use:

  • [x] Targeted PR against master branch
  • [X] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • [X] Code follows the standards mentioned here.
  • [ ] Updated relevant documentation
  • [x] Re-reviewed Files changed in the Github PR explorer
  • [ ] Added appropriate labels

nozim avatar Sep 26 '23 12:09 nozim

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (79491cf) 61.23% compared to head (de79a68) 61.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #480      +/-   ##
==========================================
- Coverage   61.23%   61.11%   -0.13%     
==========================================
  Files          26       26              
  Lines        3312     3312              
==========================================
- Hits         2028     2024       -4     
- Misses       1112     1116       +4     
  Partials      172      172              
Flag Coverage Δ
unittests 61.11% <33.33%> (-0.13%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
templates/accounts.go 16.41% <33.33%> (-2.06%) :arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 26 '23 12:09 codecov-commenter

I could add alternative methods with usage of string instead to make a smooth transition? Obviously marking existing methods as deprecated instead?

nozim avatar Sep 26 '23 12:09 nozim

I think we can make this non-breaking change: https://github.com/onflow/sdks/pull/18#issuecomment-1735471797

bluesign avatar Sep 26 '23 12:09 bluesign

Nice!

@janezpodhostnik Why would this be a breaking change?

turbolent avatar Sep 28 '23 00:09 turbolent

@janezpodhostnik the only potential breaking point I see for existing contracts already deployed in hex format. Kindly help me to understand if I miss anything here.

nozim avatar Sep 28 '23 10:09 nozim

Looking at this again... yeah sorry I thought this was a breaking change, but I see that we are only using fields already on the Contract object.

janezpodhostnik avatar Sep 28 '23 12:09 janezpodhostnik

I think onflow/sdks needs a dependency bump

updated, kindly check latest commits.

nozim avatar Oct 22 '23 17:10 nozim

I think this PR needs to be merged and release first before updating: https://github.com/onflow/sdks/pull/18

@turbolent can you confirm?

chasefleming avatar Oct 23 '23 18:10 chasefleming

@chasefleming @turbolent updated from master. Kindly check 🙏

nozim avatar Oct 30 '23 14:10 nozim

@nozim That PR I linked was not merged or released yet so updating from master would not actually address the issue.

chasefleming avatar Oct 30 '23 21:10 chasefleming