flow-emulator icon indicating copy to clipboard operation
flow-emulator copied to clipboard

Published 20 hours ago • verified publisher icon onflow

Improve block handling in remote store

Open peterargue opened this issue 2 years ago • 4 comments

Closes #???

Description

The forked mainnet functionality is helpful to testing full application integration. With the current implementation, there are some key differences between behavior of the real network and emulator, particularly with error messages and block handling.

This PR attempts to close the gap and adds testing to cover various cases to ensure block responses behave as expected.

For contributor use:

  • [x] Targeted PR against master branch
  • [ ] Linked to GitHub issue with discussion and accepted design OR link to spec that describes this work
  • [x] Code follows the standards mentioned here
  • [x] Updated relevant documentation
  • [x] Re-reviewed Files changed in the GitHub PR explorer
  • [x] Added appropriate labels

peterargue avatar Oct 25 '23 03:10 peterargue

@peterargue thanks a lot for this, btw do we have archive nodes still ? last time I tried to work on this I was failing at that.

Also if someone can fix, or at least explain to me, how flow-archive tags works, it would be great, there are 2 version stream one with v1.x another one is v0.x but I guess newer is v0.x but last time I tried archive node was using v1.x etc

bluesign avatar Oct 25 '23 08:10 bluesign

@peterargue thanks a lot for this, btw do we have archive nodes still ? last time I tried to work on this I was failing at that.

Also if someone can fix, or at least explain to me, how flow-archive tags works, it would be great, there are 2 version stream one with v1.x another one is v0.x but I guess newer is v0.x but last time I tried archive node was using v1.x etc

We are working on merging archive node functionality into access nodes as we speak. So right now the issues you are experiencing are due to that. We should have something available soon.

devbugging avatar Oct 25 '23 11:10 devbugging

I think we need to fix also register requests part, I messed up there before because of flow-archive versioning problems. ( I can make a PR for it, or contribute to this PR )

bluesign avatar Nov 04 '23 13:11 bluesign

ok I updated https://github.com/onflow/flow-emulator/pull/433 with required changes, which required a PR on flow-archive ( for conflicting go versions ) https://github.com/onflow/flow-archive/pull/143

bluesign avatar Nov 07 '23 15:11 bluesign