flow-emulator icon indicating copy to clipboard operation
flow-emulator copied to clipboard

Rollback and Snapshot support for remote storage

Open bluesign opened this issue 1 year ago • 4 comments

Description

Added rollback and snapshot support for remote storage Remote storage now can use any storage backend ( redid etc ) Added some sanity checks ( don't query blocks on archive after fork etc )


For contributor use:

  • [X] Targeted PR against master branch
  • [ ] Linked to GitHub issue with discussion and accepted design OR link to spec that describes this work
  • [X] Code follows the standards mentioned here
  • [ ] Updated relevant documentation
  • [X] Re-reviewed Files changed in the GitHub PR explorer
  • [ ] Added appropriate labels

bluesign avatar Jun 22 '23 19:06 bluesign

Codecov Report

Merging #433 (6053c52) into master (107065f) will decrease coverage by 0.61%. The diff coverage is 26.19%.

@@            Coverage Diff             @@
##           master     #433      +/-   ##
==========================================
- Coverage   54.51%   53.90%   -0.61%     
==========================================
  Files          27       27              
  Lines        3590     3651      +61     
==========================================
+ Hits         1957     1968      +11     
- Misses       1473     1522      +49     
- Partials      160      161       +1     
Flag Coverage Δ
unittests 53.90% <26.19%> (-0.61%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/utils/emulator.go 0.00% <0.00%> (ø)
storage/memstore/memstore.go 10.85% <0.00%> (-0.19%) :arrow_down:
storage/store.go 56.94% <ø> (ø)
server/server.go 55.73% <14.28%> (+1.25%) :arrow_up:
storage/remote/store.go 36.81% <27.82%> (-8.90%) :arrow_down:

codecov-commenter avatar Jun 22 '23 19:06 codecov-commenter

@janezpodhostnik btw somehow archive node version switched stuff from Paths to Registers, and broke this, I can go over this PR or make a new one to fix

bluesign avatar Jul 14 '23 16:07 bluesign

@peterargue can you help me with store_test? I tried but couldn't manage this fixture parts

bluesign avatar Jul 14 '23 19:07 bluesign

I tried to fix this, but stuck again with some conflicts @sideninja

archive, flow-go and contracts related.

bluesign avatar Jul 27 '23 15:07 bluesign