flow-core-contracts icon indicating copy to clipboard operation
flow-core-contracts copied to clipboard
verified publisher icon onflow

SoR History update

Open tarakby opened this issue 2 years ago • 2 comments

closes https://github.com/onflow/flow-core-contracts/issues/414

The implementation:

  • adds a new backfiller resource to track and backfill past empty entries in the array
  • adds events when a past gap in detected and backfillled
  • adds a minimum SoR length check
  • updates and expand tests to cover the gap cases

tarakby avatar Mar 27 '24 19:03 tarakby

Are you planning on doing this upgrade before or after Cadence 1.0? If the answer is after, I would prefer that you make these changes based on the stable-cadence branch instead of master

joshuahannan avatar Apr 01 '24 13:04 joshuahannan

Are you planning on doing this upgrade before or after Cadence 1.0?

I don't know exactly when Cadence 1.0 will be on MN. This PR change should go as soon as the the PR is merged to fix a current on-chain issue, so I guess it's gonna be before Cadence 1.0

tarakby avatar Apr 01 '24 16:04 tarakby

@joshuahannan can you please have a look? I think the PR can only be merged after your approval.

tarakby avatar Apr 15 '24 16:04 tarakby

  • https://forum.flow.com/t/upgrade-coming-to-the-randomness-history-smart-contract/5903
  • https://github.com/onflow/flow-core-contracts/issues/421

tarakby avatar Apr 15 '24 23:04 tarakby