flow-cli icon indicating copy to clipboard operation
flow-cli copied to clipboard

Use config json in home config directory to check metrics opt in status

Open sukantoraymond opened this issue 2 years ago • 2 comments

Closes #615

Description

This PR uses config.json stored in user's local machine home config directory to check if user is opted in for metrics tracking


For contributor use:

  • [x] Targeted PR against master branch
  • [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • [x] Code follows the standards mentioned here
  • [x] Updated relevant documentation
  • [x] Re-reviewed Files changed in the Github PR explorer
  • [x] Added appropriate labels

sukantoraymond avatar Aug 15 '22 22:08 sukantoraymond

Sample output of json in config.json

{
 "metrics": true
}

sukantoraymond avatar Aug 15 '22 22:08 sukantoraymond

I also don't think we need go routine for sending command usage, because we are not aggregating the command usage. There is no limit on sending API events on mixpanel. Current implementation is fine.

sukantoraymond avatar Aug 15 '22 22:08 sukantoraymond