flow-cli icon indicating copy to clipboard operation
flow-cli copied to clipboard

Published 20 hours ago • verified publisher icon onflow

Use Flow Account API for account creation

Open sukantoraymond opened this issue 2 years ago • 3 comments

Closes #597

Description

Replaces current implementation of manual account creation with the Flow Account API stated in https://github.com/Outblock/flow-account-api

For contributor use:

  • [x] Targeted PR against master branch
  • [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • [x] Code follows the standards mentioned here
  • [x] Updated relevant documentation
  • [x] Re-reviewed Files changed in the Github PR explorer
  • [x] Added appropriate labels

sukantoraymond avatar Aug 05 '22 22:08 sukantoraymond

We shouldn't change APIs just to facilitate an issue with transaction iD. As soon as I finish some work on the playground I will help you solve the transaction ID issue.

devbugging avatar Aug 24 '22 12:08 devbugging

Shouldn't we also have an API that can get tx object just by txID though? @sideninja The previous function GetTransactionResult still exists as there are other functions that require it.

sukantoraymond avatar Aug 24 '22 13:08 sukantoraymond

@sukantoraymond I don't think we need both. In any way that's a different topic, we can discuss changing the API as part of the https://github.com/onflow/flow-cli/issues/493 but again I don't think we should be doing this now just to make the API work. We need to find the problem there. Until then this should wait.

devbugging avatar Aug 24 '22 13:08 devbugging