flow-cli icon indicating copy to clipboard operation
flow-cli copied to clipboard

`flow config add deployment` incorrectly includes `previewnet` as an option

Open chasefleming opened this issue 8 months ago • 3 comments

Description:
The flow config add deployment command currently lists previewnet as one of the selectable networks. Since previewnet is deprecated, it should no longer appear as an option in the deployment configuration process. This option should be removed to prevent confusion and ensure only valid networks are presented to users.

chasefleming avatar Apr 23 '25 17:04 chasefleming

hey @chasefleming can i work on this

diego-noah avatar May 29 '25 11:05 diego-noah

@chasefleming Should we only remove previewnet from the interactive prompt in flow config add deployment, or should it be removed from all CLI commands/configurations? This would help clarify if we need to make changes in other places beyond the prompt UI. When users try to use previewnet through command flags (e.g., flow config add deployment --network previewnet), should we return an error message indicating it's deprecated? If yes, what message would you prefer to show to users?

diego-noah avatar May 29 '25 16:05 diego-noah

Hey sorry didn't see this message. Yes you can take it, thanks @diego-noah ! It should be removed from everywhere. Not sure if there is anything coming from here regarding it: https://github.com/onflow/flowkit

Do you still want to take it?

chasefleming avatar Jun 23 '25 14:06 chasefleming

hi @chasefleming, sorry I've become busy with work, I think someone else can work on this. I don't want to keep this holding.

diego-noah avatar Jul 03 '25 18:07 diego-noah

No worries, thanks for the update @diego-noah

chasefleming avatar Jul 07 '25 19:07 chasefleming