flips icon indicating copy to clipboard operation
flips copied to clipboard

Pool-Based DEX Swap Standard

Open vishalchangrani opened this issue 2 years ago • 2 comments

https://github.com/onflow/flips/blob/7992e12453be5281fbbee2423e2f579c8306380e/application/20230522-pool-based-dex.md

vishalchangrani avatar Aug 25 '23 22:08 vishalchangrani

I don't think there is a need for Capability version of the functions. What is the use case for them?

pub fun swapExactSourceToTargetTokenUsingPath(
		sourceToTargetTokenPath: Type[],
		sourceVault: @FungibleToken.Vault,
		exactTargetAmount: UFix64,
		expiry: UFix64,
		recipient: Capability<&{FungibleToken.Receiver}>,
        remainingSourceTokenRecipient: Capability<&{FungibleToken.Receiver}>
	)

bluesign avatar Aug 29 '23 17:08 bluesign

Hi @satyamakgec - were we able to make a decision on this yet?

KshitijChaudhary666 avatar Jul 23 '24 18:07 KshitijChaudhary666