fcl-js icon indicating copy to clipboard operation
fcl-js copied to clipboard

[FEATURE] Adhere to semantically versioned data structures

Open jribbink opened this issue 9 months ago • 0 comments

Issue to be solved

Currently, FCL data models (e.g. services, responses, & other nested objects) are versioned (generally v1.0.0). However, the library does not perform and form of semantically versioned matching when "normalizing" these services.

The result is that FCL is unable to comprehend a version which, by the rules of semver, should be valid. (e.g. if FCL encounters a v1.1.0 authentication service, it cannot proceed, despite the fact that it should be compatible with all v1.x.x authentication services).

This is a part of a larger protocol issue related to versioning https://github.com/onflow/flips/issues/238, however, it can likely be patched in FCL-JS independent from an FCL protocol bump. However, this wallets should not assume that FCL clients will honour semantic versioned data structures after the patch (as this assumption would break older FCL clients).

Suggest A Solution

No response

What are you currently working on that this is blocking?

No response

jribbink avatar May 17 '24 16:05 jribbink