cadence icon indicating copy to clipboard operation
cadence copied to clipboard
verified publisher icon onflow

Introduce stringer

Open RZhang05 opened this issue 1 year ago • 2 comments

Working towards #3579

Description

A simple Stringer struct interface. It is intended in the future that all types which implement Stringer can be used in string templates.

  • [x] Targeted PR against feature/string-templates branch
  • [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • [x] Code follows the standards mentioned here
  • [ ] Updated relevant documentation
  • [x] Re-reviewed Files changed in the Github PR explorer
  • [ ] Added appropriate labels

RZhang05 avatar Sep 26 '24 19:09 RZhang05

@RZhang05 is this ready to be reviewed? or are there any pending changes?

SupunS avatar Oct 01 '24 22:10 SupunS

@RZhang05 is this ready to be reviewed? or are there any pending changes?

It is ready, note that there are some questions left in the code marked with TODO however.

RZhang05 avatar Oct 01 '24 22:10 RZhang05

@SupunS Was this closed by accident?

turbolent avatar Oct 24 '24 19:10 turbolent

oh, my bad. I was cleaning up some of my old branches, and must have accidentally deleted the base branch! Thought it was protected. ~~Will revert it.~~

Restored the and reopened. Sorry about that 🙇

SupunS avatar Oct 24 '24 19:10 SupunS

No worries at all, I was just not sure about the feature branches 👍

turbolent avatar Oct 24 '24 19:10 turbolent