cadence icon indicating copy to clipboard operation
cadence copied to clipboard

WIP borrowContract for FLIP #1071

Open bluesign opened this issue 3 years ago • 1 comments
trafficstars

Closes FLIP #1071

Description

  • Tests I have to figure out.
  • Some parts I am not sure ( ensure loaded etc )
  • Docs I will update after confirmed that I am on correct path

  • [x] Targeted PR against master branch
  • [X] Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • [X] Code follows the standards mentioned here
  • [ ] Updated relevant documentation
  • [x] Re-reviewed Files changed in the Github PR explorer
  • [ ] Added appropriate labels

bluesign avatar Sep 05 '22 14:09 bluesign

Codecov Report

Merging #1934 (e27fe5a) into master (7e17bb8) will increase coverage by 0.20%. The diff coverage is 91.73%.

@@            Coverage Diff             @@
##           master    #1934      +/-   ##
==========================================
+ Coverage   77.75%   77.96%   +0.20%     
==========================================
  Files         305      308       +3     
  Lines       63629    64127     +498     
==========================================
+ Hits        49476    49995     +519     
+ Misses      12383    12334      -49     
- Partials     1770     1798      +28     
Flag Coverage Δ
unittests 77.96% <91.73%> (+0.20%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
runtime/stdlib/account.go 86.44% <84.37%> (-0.07%) :arrow_down:
runtime/interpreter/accountcontracts.go 77.46% <100.00%> (+0.65%) :arrow_up:
runtime/sema/account_contracts.go 100.00% <100.00%> (ø)
runtime/sema/authaccount_contracts.go 100.00% <100.00%> (ø)
runtime/sema/public_account_contracts.go 100.00% <100.00%> (ø)
runtime/parser/declaration.go 83.52% <0.00%> (-0.54%) :arrow_down:
runtime/parser/expression.go 90.18% <0.00%> (-0.12%) :arrow_down:
runtime/sema/check_interface_declaration.go 96.48% <0.00%> (-0.02%) :arrow_down:
tools/pretty/main.go 0.00% <0.00%> (ø)
runtime/sema/block.go 100.00% <0.00%> (ø)
... and 30 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 05 '22 14:09 codecov[bot]

@bluesign Updated to master and added tests

turbolent avatar Nov 04 '22 23:11 turbolent

Only thing that's left is documentation

turbolent avatar Nov 04 '22 23:11 turbolent

FLIP has been approved: https://github.com/onflow/flow/pull/1071

turbolent avatar Nov 16 '22 17:11 turbolent

@bluesign Could you please open a follow-up PR for documenting this? Thank you!

turbolent avatar Nov 17 '22 23:11 turbolent