onfido-sdk-ui
onfido-sdk-ui copied to clipboard
Inconsistent design between poa country select and identity country select
What was the expected behaviour?
Both the <CountrySelector>
and <RestrictedDocumentSelection>
should show the country flag images in front of the country name.
What happened instead?
When we bumped the onfido-sdk-ui version, the country flags are suddenly no longer shown causing regression.
This is presumably because of the displayFlags property not being passed to the <CountryDropdown>
by the <RestrictedDocumentSelection>
(it is for the <CountrySelector>
one).
I've discovered this comment on a PR which explains that the PoA design was not ready back in May.
https://github.com/onfido/onfido-sdk-ui/pull/1881#discussion_r885366719
Version info:
- Onfido SDK 9.0.0
Steps to reproduce:
Go to the country selector screen and notice how the <img>
tag is missing for the country <li>
's.
Reproducible demo:
https://jsfiddle.net/yha6nckx/ Yeah, it's literally just the default template + the current live demo version at https://latest-onfido-sdk-ui-onfido.surge.sh/ also has this issue
Hi @IliasDewachter
I hope you are well. My name is Thiago, I'm part of the Product Support team here at Onfido.
As I was able to reproduce this behavior, I am consolidating my research notes and I am reaching out to our Engineering team for further insights and investigation.
From here, I will touch base as soon as we have further updates.
Kind Regards, Thiago
Hi @IliasDewachter,
As you are aware, we have taken this to our development team for review. Thank you for the feedback! This design discrepancy won’t be prioritised as they see it as a low-priority (cosmetic issue). We do not have further details of what changes will be made and when this will happen to have this functionality working the wished way, but they’ll move it to their backlog.
Please accept my sincere apologies for the same and we appreciate your understanding.
If there is anything else you need help with, please do let us know.
Kind Regards, Thiago