onfido-sdk-ui
onfido-sdk-ui copied to clipboard
Allow crossdevice sms feature to be disabled by feature flag
Problem
The sms feature can't be disabled remotely
Solution
Add a feature flag to disable the sms feature when needed
TODO:
- [ ] Readme
- [ ] Wait for MR to be merged: https://gitlab.eu-west-1.mgmt.onfido.xyz/onfido/sdks/sdk-configuration-service/-/merge_requests/90
- [ ] Test against updated backend
Checklist
put n/a
if item is not relevant to PR changes
- [ ] Has the CHANGELOG been updated?
- [ ] Has the README been updated?
- [ ] Has the CONTRIBUTING doc been updated?
- [ ] Has the RELEASE_GUIDELINES been updated?
- [ ] Has the TESTING_GUIDELINES been updated?
- [ ] Has the MIGRATION doc been updated for any MAJOR breaking changes?
- [ ] Has the MIGRATION doc been updated for any MINOR breaking changes, including any translation strings or keys changes?
- [ ] Have any new automated tests been implemented or the existing ones changed?
- [ ] Have any new manual tests been written down or the existing ones changed?
- [ ] Have any new strings been translated or the existing ones changed?
https://2000-pr-onfido-sdk-ui-onfido.surge.sh 🚀 https://staging-2000-pr-onfido-sdk-ui-onfido.surge.sh 🚀
https://2000-pr-onfido-sdk-ui-onfido.surge.sh 🚀 https://staging-2000-pr-onfido-sdk-ui-onfido.surge.sh 🚀 https://prod-2000-pr-onfido-sdk-ui-onfido.surge.sh 🚀
UI Test results - Firefox
1 files 1 suites 2m 38s :stopwatch: 3 tests 3 :heavy_check_mark: 0 :zzz: 0 :x: 4 runs 4 :heavy_check_mark: 0 :zzz: 0 :x:
Results for commit 877297ed.
UI Test results - Edge
1 files 1 suites 2m 34s :stopwatch: 3 tests 3 :heavy_check_mark: 0 :zzz: 0 :x: 4 runs 4 :heavy_check_mark: 0 :zzz: 0 :x:
Results for commit 877297ed.
UI Test results - Chrome
14 files 14 suites 37m 20s :stopwatch: 143 tests 135 :heavy_check_mark: 6 :zzz: 1 :x: 1 :fire: 162 runs 152 :heavy_check_mark: 8 :zzz: 1 :x: 1 :fire:
For more details on these failures and errors, see this check.
Results for commit 877297ed.
UI Test results - Safari
1 files 1 suites 2m 40s :stopwatch: 3 tests 3 :heavy_check_mark: 0 :zzz: 0 :x: 4 runs 4 :heavy_check_mark: 0 :zzz: 0 :x:
Results for commit 877297ed.
UI Test results - IE
1 files 1 suites 2m 49s :stopwatch: 3 tests 1 :heavy_check_mark: 0 :zzz: 0 :x: 2 :fire: 4 runs 1 :heavy_check_mark: 0 :zzz: 0 :x: 3 :fire:
For more details on these errors, see this check.
Results for commit 877297ed.
I guess its too much work to convert CrossDeviceLinkUI to a func component to use a hook instead of a wrapper component ?
My train of thought was: It is a decent size component, personally I'm not sure converting everything to a functional react is a good thing. Until we have a general guideline for web maybe best to leave it as it is for now.