onfido-sdk-ui icon indicating copy to clipboard operation
onfido-sdk-ui copied to clipboard

Migrate analytics to v4

Open DannyvanderJagt opened this issue 3 years ago • 6 comments

Blocked: Waiting for backend changes

Problem

Analytics uses api v3

Solution

Use api v4

Changes need:

  • Add authorization header
  • Switch to /v4
  • Change payload to array

Checklist

put n/a if item is not relevant to PR changes

  • [x] Has the CHANGELOG been updated?
  • [ ] Has the README been updated?
  • [ ] Has the CONTRIBUTING doc been updated?
  • [ ] Has the RELEASE_GUIDELINES been updated?
  • [ ] Has the TESTING_GUIDELINES been updated?
  • [ ] Has the MIGRATION doc been updated for any MAJOR breaking changes?
  • [ ] Has the MIGRATION doc been updated for any MINOR breaking changes, including any translation strings or keys changes?
  • [ ] Have any new automated tests been implemented or the existing ones changed?
  • [ ] Have any new manual tests been written down or the existing ones changed?
  • [ ] Have any new strings been translated or the existing ones changed?

DannyvanderJagt avatar Aug 01 '22 13:08 DannyvanderJagt

https://1998-pr-onfido-sdk-ui-onfido.surge.sh 🚀 https://staging-1998-pr-onfido-sdk-ui-onfido.surge.sh 🚀

github-actions[bot] avatar Aug 01 '22 13:08 github-actions[bot]

UI Test results - Firefox

1 files  1 suites   1m 37s :stopwatch: 3 tests 3 :heavy_check_mark: 0 :zzz: 0 :x: 4 runs  4 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 7290f73b.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Aug 01 '22 13:08 github-actions[bot]

UI Test results - Chrome

  14 files    14 suites   31m 41s :stopwatch: 143 tests 137 :heavy_check_mark: 6 :zzz: 0 :x: 162 runs  154 :heavy_check_mark: 8 :zzz: 0 :x:

Results for commit 7290f73b.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Aug 01 '22 13:08 github-actions[bot]

UI Test results - Edge

1 files  1 suites   2m 27s :stopwatch: 3 tests 3 :heavy_check_mark: 0 :zzz: 0 :x: 4 runs  4 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 7290f73b.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Aug 01 '22 13:08 github-actions[bot]

UI Test results - Safari

1 files  1 suites   2m 28s :stopwatch: 3 tests 3 :heavy_check_mark: 0 :zzz: 0 :x: 4 runs  4 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 7290f73b.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Aug 01 '22 13:08 github-actions[bot]

UI Test results - IE

1 files  1 suites   2m 49s :stopwatch: 3 tests 0 :heavy_check_mark: 0 :zzz: 0 :x: 3 :fire: 4 runs  0 :heavy_check_mark: 0 :zzz: 0 :x: 4 :fire:

For more details on these errors, see this check.

Results for commit 7290f73b.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Aug 01 '22 13:08 github-actions[bot]

https://1998-pr-onfido-sdk-ui-onfido.surge.sh 🚀 https://staging-1998-pr-onfido-sdk-ui-onfido.surge.sh 🚀 https://prod-1998-pr-onfido-sdk-ui-onfido.surge.sh 🚀

github-actions[bot] avatar Aug 29 '22 14:08 github-actions[bot]

Hey @DannyvanderJagt 👋

Want to perhaps create an analytics.integration.js file with a couple of tests for such a piece of work? 💪

sergiomartins8 avatar Aug 30 '22 10:08 sergiomartins8

Merging this without integration tests: I've tried to add it but cross domain errors show up for this endpoint. Going to leave it without test for now, can revisit when there is time left in the Q: https://github.com/onfido/onfido-sdk-ui/tree/tests/analytics-v4

DannyvanderJagt avatar Sep 05 '22 12:09 DannyvanderJagt