oney

Results 64 comments of oney

Thanks! One question. Why don't you put `popInitialNotification` in `public Map getConstants()` rather than [here](https://github.com/oney/react-native-gcm-android/pull/19/files#diff-a57cf03f25917eedea5bbf81f758d5aaR190) I think putting it in `getConstants` will be more like [official react native implementation](https://github.com/facebook/react-native/blob/060664fd3d9331f062696e68179bac9cd4544a06/Libraries/PushNotificationIOS/RCTPushNotificationManager.m#L70)

Currently, this module uses https://github.com/Neson/react-native-system-notification to create notification in `0.1.7`. You can get payload of clicked notification in `DeviceEventEmitter.addListener('sysNotificationClick'` listener. Please see whether it meets your requirements. I still more...

@RGBz absolutely agree with you. I will remind the author of `react-native-system-notification` this issue, and wait him to fix it.

My opinion is same as you, directly get payload from popInitialNotification like PushNotificationIOS.popInitialNotification, not from or on a callback. I have mentioned [here](https://github.com/oney/react-native-gcm-android/pull/19#issuecomment-167283362). Because the notification is created from `react-native-system-notification`...

We create notification by using react-native-system-notification module. You can do it like below ``` javascript if (GcmAndroid.launchNotification) { var notification = GcmAndroid.launchNotification; var info = JSON.parse(notification.info); Notification.create({ subject: info.subject, message:...

Please try TestGcm project first to see whether it works. Make sure to delete other apps that use this module.

Can you try this demo project? And see whether the same error happens. https://github.com/oney/TestGcm

@jawadrehman Sure, but how to install Google Play Services?

@herby I will do

Run command `android` to open Android SDK Manager. And find Google Play Services and Google Repository in Extras like below ![SDK](http://i.imgur.com/mT4lXVT.png) It's super weird that it shows I don't install...