Kingfisher icon indicating copy to clipboard operation
Kingfisher copied to clipboard

从本地文件缓存中读取出image对象,设置backgroundDecode之后支持异步解码

Open meiyongsheng opened this issue 3 years ago • 1 comments

meiyongsheng avatar May 09 '22 04:05 meiyongsheng

从本地文件缓存中读取出image对象,设置backgroundDecode之后支持异步解码

meiyongsheng avatar May 09 '22 04:05 meiyongsheng

@onevcat 能否进行合并呢?可以的话,麻烦帮忙合并一下

meiyongsheng avatar Nov 11 '22 08:11 meiyongsheng

@danieldll099 Ask for help merging

meiyongsheng avatar Nov 11 '22 09:11 meiyongsheng

The check of options.backgroundDecode seems to be fine, but is it a must to make the original private/internal methods to be public/open? I would merge this if you can revert other changes.

onevcat avatar Nov 11 '22 11:11 onevcat

@onevcat 麻烦把53e43704f65b287d539308b09aabf57316d0e8c9 这次提交先合并。

488e6689e793cbd19c23b220b8a6dcfa01b04776这次修改的主要原因:

image 该段代码目前在我们项目中检测到性能问题,当频繁在内存中读取image时,会遇到 `joined` 这里占用时间比较多,由于目前在内存中取image是在主线程中,为了减少`joined` 函数的调用,我计划在异步执行`retrieveImage`时把cacheKey进行保留,下一次在取image时,直接使用cacheKey从内存中取

meiyongsheng avatar Nov 11 '22 13:11 meiyongsheng

@onevcat 488e6689e793cbd19c23b220b8a6dcfa01b04776 这次提交我不在打算进行合并,上面反馈的问题,我在进行修改 感谢

meiyongsheng avatar Nov 11 '22 13:11 meiyongsheng

本次提交已经改为:https://github.com/onevcat/Kingfisher/pull/2008 这次合并

meiyongsheng avatar Nov 11 '22 14:11 meiyongsheng

image 目前已经通过自定义cachekey 来解决该问题

meiyongsheng avatar Nov 11 '22 14:11 meiyongsheng