monty-python icon indicating copy to clipboard operation
monty-python copied to clipboard

Published 20 hours ago • verified publisher icon onerandomusername

fix: improve markdown list handling

Open shiftinv opened this issue 2 years ago • 3 comments
trafficstars

Fixes https://canary.discord.com/channels/755868545279328417/1093642705759899678, rewriting/fixing the (still fairly simple) codeblock detection in the process.

The first commit is a revert, the diff becomes much more readable by skipping it.

shiftinv avatar Apr 07 '23 19:04 shiftinv

deferring to when new markdown is released by Discord.

onerandomusername avatar May 04 '23 02:05 onerandomusername

deferring to when new markdown is released by Discord.

given they released it an unreleased it, i'll be adding this as part of a configuration option internally with both old and new styles

onerandomusername avatar Jun 08 '23 19:06 onerandomusername

@shiftinv would you please update this pr to follow the logic in https://github.com/onerandomusername/monty-python/commit/797738ba98f95dec59f4f3bc18020016f59a6c1f

when constants.DiscordFeatures.extended_markdown is true, then we should use discord's new markdown implementation if that's false, we should use a simplified markdown implementation.

onerandomusername avatar Jun 08 '23 20:06 onerandomusername