onepanel icon indicating copy to clipboard operation
onepanel copied to clipboard

Refactor ListWorkflowTemplateVersions inside pkg/workflow_template.go

Open aleksandrmelnikov opened this issue 4 years ago • 1 comments

Currently:

func (c *Client) ListWorkflowTemplateVersions(namespace, uid string) (workflowTemplateVersions []*WorkflowTemplate, err error) {

The issue is that this returns WorkflowTemplate instead of WorkflowTemplateVersion.

  • Initially, there was no database backing versions, so WorkflowTemplate was returned

Since we have DB backing now, we should refactor this to return the correct struct.

  • This function is used part of an API request, so it most likely impacts the UI as well.

aleksandrmelnikov avatar Jul 28 '20 00:07 aleksandrmelnikov

Issue-Label Bot is automatically applying the label kind/enhancement to this issue, with a confidence of 0.78. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

issue-label-bot[bot] avatar Jul 28 '20 00:07 issue-label-bot[bot]