onepanel icon indicating copy to clipboard operation
onepanel copied to clipboard

Refactor and Reduce YAML libraries in Core.

Open aleksandrmelnikov opened this issue 4 years ago • 1 comments

We use yaml.v3 to support reading (and writing) YAML with comments, inline comments, and other metadata. We use a pkg/config_types.go in CLI to marshal / unmarshal params.yaml Same package is used in core to dynamically generate the s3 access and secret keys, for Workflows I think, ideally, we should use yaml.v3

See: https://github.com/onepanelio/core/pull/400#discussion_r453901209

Thursday, July 23, 2020 - 09_10_47 PM

  • Ran into a specific library requirement here: https://github.com/onepanelio/core/pull/423

aleksandrmelnikov avatar Jul 14 '20 20:07 aleksandrmelnikov

Issue-Label Bot is automatically applying the label kind/enhancement to this issue, with a confidence of 0.92. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

issue-label-bot[bot] avatar Jul 14 '20 20:07 issue-label-bot[bot]