TabMixPlus icon indicating copy to clipboard operation
TabMixPlus copied to clipboard

Dreaded "Addon is corrupt" error

Open hydroculator opened this issue 1 year ago • 20 comments

I have been unable to install the addon, and receive the "addon is corrupt" message. I have read and followed every instruction and suggestion I can find in all the threads under Issues and the install instructions multiple times. I've manually verified all the advanced preferences items, I've cleared the startup cache. I've tried every version of config.js I have seen in all the threads. I've tried running the code in the browser console. I don't know what else to try. I deleted the cache folder in AppData\Local.
I've gotten this to work on my personal computer, but this one is managed by IT. I have admin rights on it, but could there be something else that I could check to see if something is overriding this somehow?

Thanks for your help and the great addon.

Profile Folder: C:\Users\redacted\AppData\Roaming\Mozilla\Firefox\Profiles\0pot7u9c.default-esr Scripts are here (I have tried both the extension only and the script and extensions zip file): C:\Users\redacted\AppData\Roaming\Mozilla\Firefox\Profiles\0pot7u9c.default-esr\chrome\utils BootstrapLoader.jsm chrome.manifest RDFDataSource.jsm RDFManifestConverter.jsm xPref.jsm

Application Binary: C:\Program Files\Mozilla Firefox\firefox.exe config.js is here: C:\Program Files\Mozilla Firefox\config.js config-prefs.js is here: C:\Program Files\Mozilla Firefox\defaults\pref\config-prefs.js

xpinstall.signatures.required: locked false extensions.install_origins.enabled: locked false general.config.obscure_value: 0 extensions.experiments.enabled: true general.config.sandbox_enabled: false devtools.chrome.enabled: true general.config.filename: config.js

However, this returns True. 1709586492507 addons.xpi WARN Invalid XPI: Error: File C:\downloads\tab_mix_plus-dev-build.xpi does not contain a valid manifest(resource://gre/modules/addons/XPIInstall.jsm:685:11) JS Stack trace: [email protected]:685:11

Contents of C:\Program Files\Mozilla Firefox\config.js:

// skip 1st line lockPref('xpinstall.signatures.required', false); lockPref('extensions.install_origins.enabled', false);

try { const cmanifest = Cc['@mozilla.org/file/directory_service;1'].getService(Ci.nsIProperties).get('UChrm', Ci.nsIFile); cmanifest.append('utils'); cmanifest.append('chrome.manifest'); Components.manager.QueryInterface(Ci.nsIComponentRegistrar).autoRegister(cmanifest);

const objRef = ChromeUtils.import('resource://gre/modules/addons/XPIDatabase.jsm'); objRef.XPIDatabase.SIGNED_TYPES.delete("extension");

Cu.import('chrome://userchromejs/content/BootstrapLoader.jsm'); } catch (ex) {};

try { Cu.import('chrome://userchromejs/content/userChrome.jsm'); } catch (ex) {};

hydroculator avatar Mar 04 '24 21:03 hydroculator

https://onemen.github.io/tabmixplus-docs/other/installation/

onemen avatar Mar 04 '24 22:03 onemen

What is yor firefox version?

onemen avatar Mar 05 '24 05:03 onemen

123.0.1 (64-bit)

hydroculator avatar Mar 06 '24 08:03 hydroculator

you only see the "Addon is corrupt" message if the scripts that allows legacy extensions to work on Firefox did not installed properly.

follow ALL installation instructions

if you are using Fifeofox 123 it is better no to use old profiles (default-esr),

onemen avatar Mar 06 '24 10:03 onemen

I also had difficulties with the new documentation and even repeating all the steps several times, I continued to receive the message that the "addon is corrupt". I decided to redo the steps, but instead of using the documentation files, I used the backup files from an installation that I used until last week and it worked the first time. I used the "test-build-1.0.0-pre.19.20240309.1.xpi" version and updated the extensions, updating the TMP to the latest version, 1.19.1.

This backup used the "old" method, which used userChromeJS

I'm using Firefox Nightly 125.0a1 (2024-03-11) (64-bit)

I would like to understand why it worked one way and not another.

ozzyjr avatar Mar 11 '24 14:03 ozzyjr

@ozzyjr,

can you provide copy of the script files you where using.

what is your operating system?

onemen avatar Mar 11 '24 14:03 onemen

Of course @onemen

I'm on a MacOs Sonoma 14.4

Files files.zip

ozzyjr avatar Mar 11 '24 17:03 ozzyjr

@ozzyjr,

I will try to check these files and the files from the dcos and see if I can reproduce this issue.

beside the different files is there anything else that i can do to improve the installation documents ?

onemen avatar Mar 11 '24 17:03 onemen

@onemen

No, the installation documents are fine. The only problem was the corrupt addon message that I couldn't resolve using the documentation files.

Other than that, your service is as excellent as ever.

ozzyjr avatar Mar 11 '24 17:03 ozzyjr

@ozzyjr ,

I have just tested the files from installation documents on my VirtualBox MacOS and I was able to install Tab Mix Plus without any problem.

One important different between utils zip file in the documents and the files you are using is that in you zip files utils folder is inside chrome folder and the documents utils folder is at the root of the zip file.

I just updated the instruction utils

onemen avatar Mar 12 '24 09:03 onemen

@onemen

OK. Thanks for the explanation and help.

ozzyjr avatar Mar 12 '24 11:03 ozzyjr

Same problem on windows, installed everything correctly, like always, but this time the corrupt message shows up. Upgraded firefox to 124.0.1 and these problems began.

edit: Forgot to uninstall Tab Mix Plus AND restart firefox before installing it. Now it works. The install doc was missing that so I almost forgot.

tekert avatar Apr 01 '24 17:04 tekert

Same issue here on Firefox 125.0.2 (64-bit), Windows 10. Did not have TabMixPlus installed before.

Should I change general.config.obscure_value from 13 to 0?

koppor avatar Apr 24 '24 06:04 koppor

Same issue here on Firefox 125.0.2 (64-bit), Windows 10. Did not have TabMixPlus installed before.

Should I change general.config.obscure_value from 13 to 0?

we already have pref("general.config.obscure_value", 0); in the file config-prefs.js - that should be copied to [PATH TO FIREFOX.EXE]/defaults/pref, if the value for "general.config.obscure_value" is 13 that is indication that you did not install Firefox Scripts properly.

onemen avatar Apr 24 '24 08:04 onemen

Thank you so much for the support! Yes, that's it! TerraCopy worked only the second time when copying.

koppor avatar Apr 24 '24 10:04 koppor

I have this occuring here too, just not for TMP, but other extensions such as bbCodeWebEx and enhanced-h264ify,

issue is directly caused with the placing of the config.js in the installer folder as removing it and restarting it allows them to install again.

Squall-Leonhart avatar May 23 '24 16:05 Squall-Leonhart

Verify that all your firefox-scripts are up-to-date https://github.com/onemen/TabMixPlus/files/14075743/fx-folder.zip https://github.com/onemen/TabMixPlus/files/14075742/utils_extensions_and_scripts.zip

onemen avatar May 23 '24 17:05 onemen

They certainly are, i only just downloaded them (from here)

I can reproduce it reliably on Waterfox G6 and Firefox whateverthehecklatest is, its just the two mentioned extensions though, i assume something to do with their signing or something, i can install most others fine.

Squall-Leonhart avatar May 23 '24 18:05 Squall-Leonhart

@Squall-Leonhart read #292

onemen avatar May 24 '24 01:05 onemen

for the record, some installations (like mine) have a defaults/pref/antibeacon.js file containing pref("general.config.filename", "mozilla.cfg"); and pref("general.config.obscure_value", 0);.

In this case, I added at the end of this file pref('general.config.sandbox_enabled', false);, and pasted all content of config.js into already existing mozilla.cfg (witch was containing a bunch of security-related lockPref)

Albirew avatar Aug 09 '24 21:08 Albirew