nova-file-manager icon indicating copy to clipboard operation
nova-file-manager copied to clipboard

add rtl support

Open FaridAghili opened this issue 8 months ago • 3 comments

I've added RTL support to this package, as Nova itself supports RTL layout.

By changing styles to use logical properties and also using correct ChevronRight/Left based on page LTR/RTL value:

ml => ms mr => me pl => ps pr => pe left => start (inset-inline-start) right => end text-left => text-start text-right => text-end origin-top-right => ltr:origin-top-right rtl:origin-top-left origin-top-left => ltr:origin-top-left rtl:origin-top-right

FaridAghili avatar Apr 11 '25 19:04 FaridAghili

Hey @FaridAghili Thanks for this

would it be possible for you to include some screenshots and/or video please? It would be great to see how it looks and how it adapts between ltr and rtl

cheers

Rezrazi avatar Apr 12 '25 18:04 Rezrazi

@Rezrazi Sure, but currently there is a problem with main branch, can't run npm install because of dependency version conflict.

npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @vue/[email protected]
npm error Found: [email protected]
npm error node_modules/eslint
npm error   dev eslint@"^9.23.0" from the root project
npm error   peer eslint@"^6.0.0 || ^7.0.0 || >=8.0.0" from @eslint-community/[email protected]
npm error   node_modules/@eslint-community/eslint-utils
npm error     @eslint-community/eslint-utils@"^4.2.0" from @typescript-eslint/[email protected]
npm error     node_modules/@typescript-eslint/type-utils/node_modules/@typescript-eslint/utils
npm error       @typescript-eslint/utils@"5.62.0" from @typescript-eslint/[email protected]
npm error       node_modules/@typescript-eslint/type-utils
npm error         @typescript-eslint/type-utils@"5.62.0" from @typescript-eslint/[email protected]
npm error         node_modules/@vue/eslint-config-typescript/node_modules/@typescript-eslint/eslint-plugin
npm error     @eslint-community/eslint-utils@"^4.2.0" from @typescript-eslint/[email protected]
npm error     node_modules/@vue/eslint-config-typescript/node_modules/@typescript-eslint/eslint-plugin/node_modules/@typescript-eslint/utils
npm error       @typescript-eslint/utils@"5.62.0" from @typescript-eslint/[email protected]
npm error       node_modules/@vue/eslint-config-typescript/node_modules/@typescript-eslint/eslint-plugin
npm error         @typescript-eslint/eslint-plugin@"^5.59.1" from @vue/[email protected]
npm error         node_modules/@vue/eslint-config-typescript
npm error     1 more (eslint)
npm error   5 more (@typescript-eslint/type-utils, ...)
npm error
npm error Could not resolve dependency:
npm error peer eslint@"^6.2.0 || ^7.0.0 || ^8.0.0" from @vue/[email protected]
npm error node_modules/@vue/eslint-config-typescript
npm error   dev @vue/eslint-config-typescript@"^11.0.3" from the root project
npm error
npm error Conflicting peer dependency: [email protected]
npm error node_modules/eslint
npm error   peer eslint@"^6.2.0 || ^7.0.0 || ^8.0.0" from @vue/[email protected]
npm error   node_modules/@vue/eslint-config-typescript
npm error     dev @vue/eslint-config-typescript@"^11.0.3" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.

FaridAghili avatar Apr 12 '25 19:04 FaridAghili

yeah it seems something went wrong with dependabot checking that

Rezrazi avatar Apr 13 '25 09:04 Rezrazi