datamon
datamon copied to clipboard
Improvements to Key enumeration of store.go
The localfs implementation needs to
-
[ ] More efficiently walk the space for localfs (faster is better)
-
[ ] The API should allow for pagination to walk an arbitrarily large number of files.
-
[ ] Support for prefix key enumeration
ref: https://github.com/karrick/godirwalk
GCS
-
[x] The API should allow for pagination to walk an arbitrarily large number of files.
-
[x] Support for prefix key enumeration
-
[x] Unit test
PR #68
localfs case addressed by #404
We might still worry about the overall efficiency of key walking on a localfs. I don't see any better solution for now.
TODO: in core, replace calls to store.Keys by iterators.
Plus: should deprecate Keys in storage.Store