rubyinstaller2 icon indicating copy to clipboard operation
rubyinstaller2 copied to clipboard

What tests are run on ruby-head builds?

Open eregon opened this issue 5 years ago • 0 comments

What tests are run on ruby-head builds by rubyinstaller2?

@MSP-Greg expressed some concern about this and I agree it seems important for head builds to be stable enough, as sometimes breaking changes are pushed to ruby/ruby master, and those builds should not be exposed to e.g. CI users.

I think it would be important to run test-all and test-spec (like done here for non-Windows ruby-head builds).

Currently it seems test-all is not run for ruby-head builds: https://github.com/oneclick/rubyinstaller2-packages/blob/63699f6b8155435cbb499f60de6e534c107fe9bd/mingw-w64-ruby-head/PKGBUILD#L69-L70

Is it that PKGBUILD that builds https://github.com/oneclick/rubyinstaller2/releases/rubyinstaller-head ?

What about test-spec?

It seems specs are run in https://ci.appveyor.com/project/larskanis/rubyinstaller2-hbuor/build/job/3ny2rok0x5jg5xt8 and only a couple tests from test-all (TestStdlib/TestModule).

I'm unsure if that jobs actually builds Ruby or just downloads it from somewhere, as I don't see any build output related to building Ruby itself.

The 2 spec failures are odd, since the commit changing that behavior changed both implementation and spec at the same time: https://github.com/ruby/ruby/commit/5b29ea0845c14092abd866ce0183c52635bade4c One needs to use the specs at https://github.com/ruby/ruby/tree/master/spec/ruby to test ruby master (test-spec uses those), not https://github.com/ruby/spec as that has no guarantee to pass with changes in ruby master.

eregon avatar Feb 22 '20 13:02 eregon