ember-models-table icon indicating copy to clipboard operation
ember-models-table copied to clipboard

Published 20 hours ago • verified publisher icon onechiporenko

Fix select component invocation

Open 2hu12 opened this issue 2 years ago • 1 comments

component helper invocation does not support appending class argument to the html classname as the angle bracket component invocation do, so change it angle bracket invocation.

2hu12 avatar Sep 23 '22 13:09 2hu12

Coverage Status

Coverage remained the same at 81.7% when pulling cc45863babc7b7ca94234111947e80f211ea7cab on 2hu12:fix-select-component-invocation into c5a1321fc50668363b9bbd29a77568fe9572eb71 on onechiporenko:master.

coveralls avatar Sep 23 '22 13:09 coveralls

Hi, @2hu12. Thanks for PR! Am I right that @themeInstance.input now is not added to the select?

onechiporenko avatar Sep 28 '22 10:09 onechiporenko

I remove the themeInstance.input here on purpose, cause select components of all themes in ember-models-table already have it in the class attribute.

2hu12 avatar Sep 28 '22 10:09 2hu12

Merged. Thanks a lot again! :)

onechiporenko avatar Sep 28 '22 10:09 onechiporenko