compose-collapsing-toolbar icon indicating copy to clipboard operation
compose-collapsing-toolbar copied to clipboard

Snapping

Open RareScrap opened this issue 4 years ago • 10 comments

Issue #14

  • Extracted defaults

RareScrap avatar Nov 07 '21 12:11 RareScrap

@RareScrap I have scanned your code so far, I have some possible options that can deal with the difficulties you have pointed at #14.

For scroll strategies other than ExitUntilCollapsed, they need to modify offsetY which is a member of CollapsingToolbarScaffoldState. The cause derives from the fact that snap behavior is actually a feature of CollapsingToolbarScaffold. I expect the problem would be fixed if you move the snapping methods to ScaffoldState.

And for interrupting animation with user inputs, I think it may be solved by utilizing MutatePriority though it may need some extra researches.

onebone avatar Nov 14 '21 07:11 onebone

Thank you for your review. I was little busy last weekend. Will done with PR at this weekend.

RareScrap avatar Nov 25 '21 05:11 RareScrap

Great!

onebone avatar Nov 25 '21 11:11 onebone

There are many TODOs that require your attension. Please comment on each of them so we can discuss them.

RareScrap avatar Dec 01 '21 06:12 RareScrap

Thank you for reminding, I will review it until this weekend!

onebone avatar Dec 02 '21 08:12 onebone

@onebone what are the plans for merging this PR?

ChristopherKlammt avatar Jan 17 '22 12:01 ChristopherKlammt

There is a bug in it. I will describe it tomorrow.

RareScrap avatar Jan 17 '22 16:01 RareScrap

Sorry guys, I was too busy to done with it but now I have some time :)

RareScrap avatar Mar 21 '22 10:03 RareScrap

Rooting for that snapping guys! :)

jkwiecien avatar May 17 '22 09:05 jkwiecien

Hi, I created a newer version of the snapping feature here: https://github.com/onebone/compose-collapsing-toolbar/pull/83

PR contains the recorded gifs and you can test it by yourself. For me, it seems like everything is working fine.

GIGAMOLE avatar May 08 '23 14:05 GIGAMOLE